Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-31 Thread Amit Kapila
On Tue, Apr 1, 2014 at 12:24 AM, Robert Haas wrote: > On Mon, Mar 31, 2014 at 12:35 AM, Amit Kapila wrote: >> On Wed, Mar 26, 2014 at 11:32 AM, Robert Haas wrote: >>> I'm not really too sure >>> whether it makes sense to try to make an automated recommendation >>> here, or maybe only in egregio

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-31 Thread Robert Haas
On Mon, Mar 31, 2014 at 12:35 AM, Amit Kapila wrote: > On Wed, Mar 26, 2014 at 11:32 AM, Robert Haas wrote: >> On Sun, Mar 9, 2014 at 5:28 PM, Wang, Jing wrote: >>> Enclosed is the patch to implement the requirement that issue log message to >>> suggest VACUUM FULL if a table is nearly empty. >>

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-30 Thread Amit Kapila
On Wed, Mar 26, 2014 at 11:32 AM, Robert Haas wrote: > On Sun, Mar 9, 2014 at 5:28 PM, Wang, Jing wrote: >> Enclosed is the patch to implement the requirement that issue log message to >> suggest VACUUM FULL if a table is nearly empty. >> >> The requirement comes from the Postgresql TODO list. >>

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-25 Thread Robert Haas
On Sun, Mar 9, 2014 at 5:28 PM, Wang, Jing wrote: > Enclosed is the patch to implement the requirement that issue log message to > suggest VACUUM FULL if a table is nearly empty. > > The requirement comes from the Postgresql TODO list. > > If the relpage of the table > RELPAGES_VALUES_THRESHOLD(de

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-23 Thread Wang, Jing
On Thursday, 20 March 2014 2:45 PM, Amit Kapila wrote: >On Wed, Mar 19, 2014 at 6:25 AM, Wang, Jing wrote: >> On Friday, 14 March 2014 2:42 PM, Amit Kapila >> wrote: >>> I think it might be okay to even change this API to return the >>> FreeSpace, as the other place it is used is for Index Vac

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-19 Thread Amit Kapila
On Wed, Mar 19, 2014 at 6:25 AM, Wang, Jing wrote: > On Friday, 14 March 2014 2:42 PM, Amit Kapila wrote: >> I think it might be okay to even change this API to return the FreeSpace, as >> the other place it is used is for Index Vacuum, so even if we don't have any >> intention to print such a

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-18 Thread Wang, Jing
On Friday, 14 March 2014 2:42 PM, Amit Kapila wrote: >On Wed, Mar 12, 2014 at 12:22 PM, Haribabu Kommi >wrote: >> On Tue, Mar 11, 2014 at 2:59 PM, Amit Kapila wrote: >> >>> By the way have you checked if FreeSpaceMapVacuum() can serve your >>> purpose, because this call already traverses FSM i

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-13 Thread Amit Kapila
On Wed, Mar 12, 2014 at 12:22 PM, Haribabu Kommi wrote: > On Tue, Mar 11, 2014 at 2:59 PM, Amit Kapila wrote: > >> By the way have you checked if FreeSpaceMapVacuum() can serve your >> purpose, because this call already traverses FSM in depth-first order to >> update the freespace. So may be by u

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-11 Thread Haribabu Kommi
On Tue, Mar 11, 2014 at 2:59 PM, Amit Kapila wrote: > On Mon, Mar 10, 2014 at 1:13 PM, Haribabu Kommi > wrote: >> On Mon, Mar 10, 2014 at 4:24 PM, Amit Kapila wrote: >>> On Mon, Mar 10, 2014 at 5:58 AM, Wang, Jing >>> wrote: >>> > Enclosed is the patch to implement the requirement that issue l

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-10 Thread Amit Kapila
On Mon, Mar 10, 2014 at 1:13 PM, Haribabu Kommi wrote: > On Mon, Mar 10, 2014 at 4:24 PM, Amit Kapila wrote: >> On Mon, Mar 10, 2014 at 5:58 AM, Wang, Jing >> wrote: >> > Enclosed is the patch to implement the requirement that issue log message >> > to >> > suggest VACUUM FULL if a table is ne

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-10 Thread Haribabu Kommi
On Mon, Mar 10, 2014 at 4:24 PM, Amit Kapila wrote: > > On Mon, Mar 10, 2014 at 5:58 AM, Wang, Jing wrote: > > Enclosed is the patch to implement the requirement that issue log message to > > suggest VACUUM FULL if a table is nearly empty. > > > > The requirement comes from the Postgresql TODO li

Re: [HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-09 Thread Amit Kapila
On Mon, Mar 10, 2014 at 5:58 AM, Wang, Jing wrote: > Enclosed is the patch to implement the requirement that issue log message to > suggest VACUUM FULL if a table is nearly empty. > > The requirement comes from the Postgresql TODO list. > > [Solution details] > > A check function is added in the f

[HACKERS] issue log message to suggest VACUUM FULL if a table is nearly empty

2014-03-09 Thread Wang, Jing
Hi Enclosed is the patch to implement the requirement that issue log message to suggest VACUUM FULL if a table is nearly empty. The requirement comes from the Postgresql TODO list. [Benefit] To find which table is nearly empty and suggest using 'VACUUM FULL' to release the unused disk sp