Re: [HACKERS] lock on object is already held

2013-11-30 Thread Pavel Stehule
Hello, we found this issue year ago - http://www.postgresql.org/message-id/cafj8prahvzupfbx+8ey-xhfwbo8bxvu_ynmbapsdj8w-ara...@mail.gmail.com I try to simulate this error, but without success - so I prepared patch that had to help with identification of this issue. Important part is backport pro

Re: [HACKERS] lock on object is already held

2013-11-29 Thread Tom Lane
Daniel Wood writes: > ... Presuming your fix is putting PG_SETMASK(&UnBlockSig) > immediately before each of the 6 calls to ereport(ERROR,...) I've been > running the stress test with both this fix and the lock already held fix. I'm now planning to put it in error cleanup instead, but that's good

Re: [HACKERS] lock on object is already held

2013-11-28 Thread Tom Lane
I wrote: > Daniel Wood writes: >> Does the original version of my stress test not repro the problem on 9.2? > [ tries it ... ] No, it doesn't, or at least the MTBF is a couple orders > of magnitude better than on 9.3. Oh, of course: the reason the test doesn't fail as given on 9.2 is that 9.2 d

Re: [HACKERS] lock on object is already held

2013-11-27 Thread Tom Lane
Daniel Wood writes: > Does the original version of my stress test not repro the problem on 9.2? [ tries it ... ] No, it doesn't, or at least the MTBF is a couple orders of magnitude better than on 9.3. Another odd thing (seen with my short version as well as your original) is that 9.3/HEAD run

Re: [HACKERS] lock on object is already held

2013-11-26 Thread Daniel Wood
Does the original version of my stress test not repro the problem on 9.2? My primary concern with the fix is that I simply didn't understand what might happen after a failed lock attempt called CleanUpLock freeing the PROCLOCK but leaving some LOCALLOCK still pointing at it. As long as "nLocks ==

Re: [HACKERS] lock on object is already held

2013-11-26 Thread Tom Lane
Daniel Wood writes: > Sorry but I don't know how to respond to an old thread I found on > postgresql.org: > http://www.postgresql.org/message-id/20766.1357318...@sss.pgh.pa.us > I presume this is still an open issue. While working on a new feature I > wrote a stress test for it. After fixing my

Re: [HACKERS] lock on object is already held

2013-11-18 Thread Tom Lane
Daniel Wood writes: > Sorry but I don't know how to respond to an old thread I found on > postgresql.org: > http://www.postgresql.org/message-id/20766.1357318...@sss.pgh.pa.us > I presume this is still an open issue. While working on a new feature I > wrote a stress test for it. After fixing my

[HACKERS] lock on object is already held

2013-11-18 Thread Daniel Wood
Sorry but I don't know how to respond to an old thread I found on postgresql.org: http://www.postgresql.org/message-id/20766.1357318...@sss.pgh.pa.us I presume this is still an open issue. While working on a new feature I wrote a stress test for it. After fixing my bugs, I couldn't get rid of: E