Hello, sorry for annoying you with meaningless questions.
Your explanation made it far clearer to me.
This will be the last message I mention on this patch..
On 2013-12-05 22:03:51 +0900, Kyotaro HORIGUCHI wrote:
> > > - You assined HeapTupleGetOid(tuple) into relid to read in
> > >several
Hi,
On 2013-12-05 22:03:51 +0900, Kyotaro HORIGUCHI wrote:
> > > - You assined HeapTupleGetOid(tuple) into relid to read in
> > >several points but no modification. Nevertheless, you left
> > >HeapTupleGetOid not replaced there. I think 'relid' just for
> > >repeated reading has far s
Hello,
> Will send the rebased version as soon as I've addressed your comments.
Thank you.
> > = 0001:
> >
> > - You assined HeapTupleGetOid(tuple) into relid to read in
> >several points but no modification. Nevertheless, you left
> >HeapTupleGetOid not replaced there. I think 're
On 2013-12-04 17:31:50 +0900, Kyotaro HORIGUCHI wrote:
> = 0009:
>
> - In repl_scanner.l, you omitted double-doublequote handling for
>replication but it should be implemented. Zero-length
>identifier check might be needed depending on the upper-layer.
I am not sure what you mean he
Hello, this is cont'd comments.
> 0008 and after to come later..
I had nothing to comment for patch 0008.
= 0009:
- In repl_scanner.l, you omitted double-doublequote handling for
replication but it should be implemented. Zero-length
identifier check might be needed depending on the
On 2013-12-03 19:15:53 +0900, Kyotaro HORIGUCHI wrote:
> - In heapam.c, it seems to be better replacing t_self only
>during logical decoding.
I don't see what'd be gained by that except make the test matrix bigger
at no gain.
> - Before that, In LogicalDecodingAcquireFreeSlot, lock window
>
Hi,
On 2013-12-03 17:13:05 +0900, Kyotaro HORIGUCHI wrote:
> - Some patches have line offset to master. Rebase needed.
Will send the rebased version as soon as I've addressed your comments.
> = 0001:
>
> - You assined HeapTupleGetOid(tuple) into relid to read in
>several points but no
On Tue, Dec 3, 2013 at 8:18 AM, Andres Freund wrote:
>> I've taken a crack at rewriting
>> this logic, and the result looks cleaner and simpler to me, but I
>> haven't tested it beyond the fact that it passes make check. See what
>> you think.
>
> Hm. I think it actually will not abort early in
On Tue, Dec 3, 2013 at 8:24 AM, Andres Freund wrote:
> On 2013-11-28 21:15:18 -0500, Robert Haas wrote:
>> OK, I've committed the patch to adjust the definition of
>> IsSystemRelation()/IsSystemClass() and add
>> IsCatalogRelation()/IsCatalogClass().
>
> Thanks for taking care of this!
>
>> I kib
Hi,
On 2013-11-28 21:15:18 -0500, Robert Haas wrote:
> OK, I've committed the patch to adjust the definition of
> IsSystemRelation()/IsSystemClass() and add
> IsCatalogRelation()/IsCatalogClass().
Thanks for taking care of this!
> I kibitzed your decision about
> which function to use in a few
On 2013-11-29 01:16:39 -0500, Robert Haas wrote:
> On Thu, Nov 14, 2013 at 8:46 AM, Andres Freund wrote:
> > [ new patches ]
>
> Here's an updated version of patch #2. I didn't really like the
> approach you took in the documentation, so I revised it.
Fair enough.
> Apart from that, I spent a
Hello, this is continued comments.
> = 0004:
> To be continued to next mail.
= 0005:
- In heapam.c, it seems to be better replacing t_self only
during logical decoding.
- In GetOldestXmin(), the parameter name 'alreadyLocked' would
be better being simplly 'nolock' since al
Hello, This is rather trivial and superficial comments as not
fully gripping functions of this patchset.
- Some patches have line offset to master. Rebase needed.
Other random comments follows,
= 0001:
- You assined HeapTupleGetOid(tuple) into relid to read in
several points but no modi
On Thu, Nov 14, 2013 at 8:46 AM, Andres Freund wrote:
> On 2013-11-12 18:50:33 +0100, Andres Freund wrote:
>> > You've actually changed the meaning of this section (and not in a good
>> > way):
>> >
>> > be set at server start. wal_level must be set
>> > -to archive or hot_standb
On Thu, Nov 14, 2013 at 11:46 AM, Andres Freund
wrote:
>
> On 2013-11-12 18:50:33 +0100, Andres Freund wrote:
> > > You've actually changed the meaning of this section (and not in a
good way):
> > >
> > > be set at server start. wal_level must be set
> > > -to archive or hot_stand
15 matches
Mail list logo
