Re: [HACKERS] mcxt.c

2003-09-08 Thread Serguei Mokhov
> Date: Mon, 08 Sep 2003 09:57:30 -0400 > From: Tom Lane <[EMAIL PROTECTED]> > > "Gaetano Mendola" <[EMAIL PROTECTED]> writes: > > "Tom Lane" <[EMAIL PROTECTED]> wrote: > >> This seems inappropriate to me. Are you going to suggest that every > >> routine that takes a pointer parameter needs to ex

Re: [HACKERS] mcxt.c

2003-09-08 Thread Gaetano Mendola
"Tom Lane" <[EMAIL PROTECTED]> wrote: > "Gaetano Mendola" <[EMAIL PROTECTED]> writes: > > "Tom Lane" <[EMAIL PROTECTED]> wrote: > >> This seems inappropriate to me. Are you going to suggest that every > >> routine that takes a pointer parameter needs to explicitly test for > >> null? > > > Of cou

Re: [HACKERS] mcxt.c

2003-09-08 Thread Tom Lane
"Gaetano Mendola" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> wrote: >> This seems inappropriate to me. Are you going to suggest that every >> routine that takes a pointer parameter needs to explicitly test for >> null? > Of course I'm not suggesting this, what I'm suggesting is

Re: [HACKERS] mcxt.c

2003-09-08 Thread Gaetano Mendola
"Tom Lane" <[EMAIL PROTECTED]> wrote: > "Mendola Gaetano" <[EMAIL PROTECTED]> writes: > > A test for null string is missing here: > > > MemoryContextStrdup(MemoryContext context, const char *string) > > { > > char *nstr; > > - > > - if ( !string ) > > - { > > - elog(ERROR, "MemoryContextStrdup cal