Re: [HACKERS] md.c should not call files relations

2009-08-05 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Want me to change those or are you on it already? I'm going to bed --- if you wanna do it, have at it ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] md.c should not call files relations

2009-08-05 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Want me to change those or are you on it already? I'm going to bed --- if you wanna do it, have at it ... Ok. I note that many of the messages currently print the relpath() of the relation, and don't include the

Re: [HACKERS] md.c should not call files relations

2009-08-05 Thread David E. Wheeler
On Aug 4, 2009, at 11:10 PM, Tom Lane wrote: Want me to change those or are you on it already? I'm going to bed --- if you wanna do it, have at it ... Oh please. Everyone knows that you don't sleep, Tom. You just sit back in your chair and power nap for five minutes once in a while,

Re: [HACKERS] md.c should not call files relations

2009-08-05 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: I note that many of the messages currently print the relpath() of the relation, and don't include the affected segment suffix. For example: could not read block 14 of relation base/11566/24614: read only 1 of 8192 bytes If

Re: [HACKERS] md.c should not call files relations

2009-08-05 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: I note that many of the messages currently print the relpath() of the relation, and don't include the affected segment suffix. For example: could not read block 14 of relation base/11566/24614: read only 1

[HACKERS] md.c should not call files relations

2009-08-04 Thread Tom Lane
There's an interesting thread over here http://archives.postgresql.org/pgsql-sql/2009-08/msg00013.php in which someone mistook a filesystem-level permissions problem for a database permissions problem. It wasn't exactly his fault, I think, since the message he was presented with was ERROR:

Re: [HACKERS] md.c should not call files relations

2009-08-04 Thread David E. Wheeler
On Aug 4, 2009, at 6:30 PM, Tom Lane wrote: Comments? +1 Seems like a no-brainer. David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] md.c should not call files relations

2009-08-04 Thread Heikki Linnakangas
Tom Lane wrote: There's an interesting thread over here http://archives.postgresql.org/pgsql-sql/2009-08/msg00013.php in which someone mistook a filesystem-level permissions problem for a database permissions problem. It wasn't exactly his fault, I think, since the message he was presented