Re: [HACKERS] new createuser option for replication role

2011-09-26 Thread Fujii Masao
On Fri, Sep 23, 2011 at 10:47 PM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 2011/9/23 Robert Haas robertmh...@gmail.com: On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao masao.fu...@gmail.com wrote: Agreed. Attached is the updated version of the patch. It adds two options

Re: [HACKERS] new createuser option for replication role

2011-09-23 Thread Robert Haas
On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao masao.fu...@gmail.com wrote: Agreed. Attached is the updated version of the patch. It adds two options --replication and --no-replication. If neither specified, neither REPLICATION nor NOREPLICATION is specified in CREATE ROLE, i.e., in this case,

Re: [HACKERS] new createuser option for replication role

2011-09-23 Thread Cédric Villemain
2011/9/23 Robert Haas robertmh...@gmail.com: On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao masao.fu...@gmail.com wrote: Agreed. Attached is the updated version of the patch. It adds two options --replication and --no-replication. If neither specified, neither REPLICATION nor NOREPLICATION is

Re: [HACKERS] new createuser option for replication role

2011-09-23 Thread Cédric Villemain
2011/9/23 Cédric Villemain cedric.villemain.deb...@gmail.com: 2011/9/23 Robert Haas robertmh...@gmail.com: On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao masao.fu...@gmail.com wrote: Agreed. Attached is the updated version of the patch. It adds two options --replication and --no-replication. If

Re: [HACKERS] new createuser option for replication role

2011-09-22 Thread Cédric Villemain
Hello Before doing the complete review, I hit a regression with 9.1 createrole. the command ''createuser -e -s foo produce : CREATE ROLE foo SUPERUSER CREATEDB CREATEROLE INHERIT LOGIN NOREPLICATION; before it was: CREATE ROLE foo SUPERUSER CREATEDB CREATEROLE INHERIT LOGIN; The

Re: [HACKERS] new createuser option for replication role

2011-09-22 Thread Fujii Masao
On Thu, Sep 22, 2011 at 10:55 PM, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: Before doing the complete review, I hit a regression with 9.1 createrole. Thanks! the command ''createuser -e -s foo produce :  CREATE ROLE foo SUPERUSER CREATEDB CREATEROLE INHERIT LOGIN

Re: [HACKERS] new createuser option for replication role

2011-09-10 Thread Fujii Masao
On Sat, Sep 10, 2011 at 2:08 PM, Fujii Masao masao.fu...@gmail.com wrote: Currently createuser cannot create a role with REPLICATION privilege because it doesn't have any option to do that. Which sometimes annoys me when setting up replication. I'd like to propose to add new options -x

Re: [HACKERS] new createuser option for replication role

2011-09-10 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: Currently createuser cannot create a role with REPLICATION privilege because it doesn't have any option to do that. Which sometimes annoys me when setting up replication. I'd like to propose to add new options -x (--replication) and -X

Re: [HACKERS] new createuser option for replication role

2011-09-10 Thread Fujii Masao
On Sat, Sep 10, 2011 at 11:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: Currently createuser cannot create a role with REPLICATION privilege because it doesn't have any option to do that. Which sometimes annoys me when setting up replication. I'd like to

[HACKERS] new createuser option for replication role

2011-09-09 Thread Fujii Masao
Hi, Currently createuser cannot create a role with REPLICATION privilege because it doesn't have any option to do that. Which sometimes annoys me when setting up replication. I'd like to propose to add new options -x (--replication) and -X (--no-replication) into createuser. -x allows the new