Re: [HACKERS] passing diff options to pg_regress

2013-01-29 Thread Peter Eisentraut
On Wed, 2013-01-16 at 14:35 +0530, Jeevan Chalke wrote: > However, I think you need to add this in docs. Letting people know > about this environment variable to make use of that. Done and committed. Thanks. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make change

Re: [HACKERS] passing diff options to pg_regress

2013-01-16 Thread Jeevan Chalke
Hi Peter, Idea is really very good. About the patch: Patch looks good to me. Applied cleanly on latest sources. make / make install / make check / initdb everything works well. Tested with few options and it is working well. However, I think you need to add this in docs. Letting people know abo

Re: [HACKERS] passing diff options to pg_regress

2013-01-15 Thread Robert Haas
On Mon, Jan 14, 2013 at 6:57 AM, Peter Eisentraut wrote: > I sometimes find it useful to view a regression test difference using > other diff options, such as -u -w or more context. There is currently > no easy way to accomplish that. > > I suggest allowing to override the diff options using an e

Re: [HACKERS] passing diff options to pg_regress

2013-01-14 Thread Andres Freund
On 2013-01-14 06:57:52 -0500, Peter Eisentraut wrote: > I sometimes find it useful to view a regression test difference using > other diff options, such as -u -w or more context. There is currently > no easy way to accomplish that. > > I suggest allowing to override the diff options using an envi

[HACKERS] passing diff options to pg_regress

2013-01-14 Thread Peter Eisentraut
I sometimes find it useful to view a regression test difference using other diff options, such as -u -w or more context. There is currently no easy way to accomplish that. I suggest allowing to override the diff options using an environment variable, such as PG_REGRESS_DIFF_OPTS. The patch is ve