Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-17 Thread Tom Lane
George Gensure wer...@gmail.com writes: There's some tricky stuff in here to say the least. Doesn't look like param names are kept anywhere past the parser - gonna have to have it follow through a bunch of functions to reach parse_(fixed|variable)_parameters. The p_post_columnref_hook you

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-17 Thread Alvaro Herrera
Tom Lane escribió: George Gensure wer...@gmail.com writes: I've put together a small patch to provide a schema name in an fk violation in deference to the todo item Report the schema along table name in a referential failure error message This is not the way forward; if it were, we would

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-16 Thread George Gensure
On Sun, Nov 15, 2009 at 1:43 PM, Andrew Dunstan and...@dunslane.net wrote: George Gensure wrote: This begs a bigger question:  what's *really* easy or low barrier to entry for very light contributors like myself? - I've got time, I like the product, I need to know what's going to get you a

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Tom Lane
George Gensure wer...@gmail.com writes: I've put together a small patch to provide a schema name in an fk violation in deference to the todo item Report the schema along table name in a referential failure error message This is not the way forward; if it were, we would have done it years ago.

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread George Gensure
On Sun, Nov 15, 2009 at 11:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: George Gensure wer...@gmail.com writes: I've put together a small patch to provide a schema name in an fk violation in deference to the todo item Report the schema along table name in a referential failure error message

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Andrew Dunstan
George Gensure wrote: This begs a bigger question: what's *really* easy or low barrier to entry for very light contributors like myself? - I've got time, I like the product, I need to know what's going to get you a win, I may not be gunning particularly for the feature myself. The TODO

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: George Gensure wrote: This begs a bigger question: what's *really* easy or low barrier to entry for very light contributors like myself? The TODO list at http://wiki.postgresql.org/wiki/Todo doesn't seem to have a huge number or [E] items. Maybe

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Brendan Jurd
2009/11/16 Tom Lane t...@sss.pgh.pa.us: The real problem with the entry that George picked up on was that it was misdescribed and mislabeled as easy because whoever put it in ignored the fact that there was not a consensus to do a half-baked fix ... this is a problem with a wiki TODO list :-(

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Tom Lane
Brendan Jurd dire...@gmail.com writes: However, I'm not sure how productive the [E]asy marker can really be. Items end up on the TODO generally because a) we couldn't settle on a way forward, or b) nobody was keen to do it right away. There just aren't many genuinely easy items in there, easy

Re: [HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-15 Thread Andrew Dunstan
Tom Lane wrote: Yeah, that is a real problem for new would-be contributors --- there simply isn't that much low-hanging fruit waiting for them, unless they focus on areas that no one else has taken much interest in; and even then there are few really small tasks.

[HACKERS] patch - Report the schema along table name in a referential failure error message

2009-11-14 Thread George Gensure
I've put together a small patch to provide a schema name in an fk violation in deference to the todo item Report the schema along table name in a referential failure error message The error message only contains the schema if the table name being referenced is non-unique or not present in the