Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-19 Thread Bruce Momjian
Applied by Alvaro. Thanks. --- Larry Rosenman wrote: Larry Rosenman wrote: Greetings, I've got a patch to be reviewed for having the stats system keep track of the last time a table was vacuumed or analyzed

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-04 Thread Jim C. Nasby
On Wed, May 03, 2006 at 02:25:54PM -0400, Tom Lane wrote: On Tue, May 02, 2006 at 05:49:33PM -0500, Jim C. Nasby wrote: Back in the discussion of this someone had mentioned capturing all the info that you'd get from a vacuum verbose; dead tuples, etc. What do people think about that? In

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-04 Thread Tom Lane
Jim C. Nasby [EMAIL PROTECTED] writes: On Wed, May 03, 2006 at 02:25:54PM -0400, Tom Lane wrote: Isn't this already dealt with by contrib/pg_freespacemap? AFAIK that does nothing to tell you how much space is desired by relations. I thought the latest patch arranged to expose per-relation

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-04 Thread Jim C. Nasby
On Thu, May 04, 2006 at 01:20:32PM -0400, Tom Lane wrote: Jim C. Nasby [EMAIL PROTECTED] writes: On Wed, May 03, 2006 at 02:25:54PM -0400, Tom Lane wrote: Isn't this already dealt with by contrib/pg_freespacemap? AFAIK that does nothing to tell you how much space is desired by

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-04 Thread Tom Lane
Jim C. Nasby [EMAIL PROTECTED] writes: After CVS-upping... yes, both lastpagecount and nextpage are now included. But unfortunately the README says next to nothing about what they mean... Yeah, this needs a bit of work ... will have at it. regards, tom lane

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-03 Thread Martijn van Oosterhout
On Tue, May 02, 2006 at 05:49:33PM -0500, Jim C. Nasby wrote: Back in the discussion of this someone had mentioned capturing all the info that you'd get from a vacuum verbose; dead tuples, etc. What do people think about that? In particular I think it'd be handy to know how many pages vacuum

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-03 Thread Jim C. Nasby
On Wed, May 03, 2006 at 03:54:57PM +0200, Martijn van Oosterhout wrote: On Tue, May 02, 2006 at 05:49:33PM -0500, Jim C. Nasby wrote: Back in the discussion of this someone had mentioned capturing all the info that you'd get from a vacuum verbose; dead tuples, etc. What do people think

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-03 Thread Tom Lane
On Tue, May 02, 2006 at 05:49:33PM -0500, Jim C. Nasby wrote: Back in the discussion of this someone had mentioned capturing all the info that you'd get from a vacuum verbose; dead tuples, etc. What do people think about that? In particular I think it'd be handy to know how many pages vacuum

[HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-02 Thread Larry Rosenman
Greetings, I've got a patch to be reviewed for having the stats system keep track of the last time a table was vacuumed or analyzed either by the user or via AutoVacuum. The patch is at: http://www.lerctr.org/~ler/pg-dev/vacuum-autovacuum-times-stats.diff I'd appreciate a full review, it

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-02 Thread Larry Rosenman
Larry Rosenman wrote: Greetings, I've got a patch to be reviewed for having the stats system keep track of the last time a table was vacuumed or analyzed either by the user or via AutoVacuum. The patch is at: http://www.lerctr.org/~ler/pg-dev/vacuum-autovacuum-times-stats.diff I'd

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-02 Thread Martijn van Oosterhout
Looks good to me. Short and sweet. On Tue, May 02, 2006 at 01:18:03PM -0500, Larry Rosenman wrote: Greetings, I've got a patch to be reviewed for having the stats system keep track of the last time a table was vacuumed or analyzed either by the user or via AutoVacuum. The patch is at:

Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.

2006-05-02 Thread Jim C. Nasby
Back in the discussion of this someone had mentioned capturing all the info that you'd get from a vacuum verbose; dead tuples, etc. What do people think about that? In particular I think it'd be handy to know how many pages vacuum wanted in the FSM vs. how many it got; this would make it much