Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-30 Thread José Luis Tallón
On 12/30/2015 06:46 AM, Simon Riggs wrote: On 30 December 2015 at 00:17, Joe Conway > wrote: On 12/29/2015 07:15 AM, Tom Lane wrote: > Yeah. Use of the same x/y notation with two different bases seems like > a recipe for

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-30 Thread Tom Lane
=?UTF-8?B?Sm9zw6kgTHVpcyBUYWxsw7Nu?= writes: > On 12/30/2015 06:46 AM, Simon Riggs wrote: >> There is already long precedent about how to represent an XID with an >> epoch... and it is neither of those two formats. > IMHO, we have been telling users that XIDs are

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-29 Thread Tom Lane
=?UTF-8?B?Sm9zw6kgTHVpcyBUYWxsw7Nu?= writes: > On 12/29/2015 01:18 PM, Heikki Linnakangas wrote: >> On 29/12/15 07:14, Joe Conway wrote: >>> Shouldn't it use "%X/%X", same as e.g. "Prior checkpoint location" and >>> all the other XIDs? >> No. The "locations" in the

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-29 Thread Joe Conway
On 12/29/2015 07:15 AM, Tom Lane wrote: > Yeah. Use of the same x/y notation with two different bases seems like > a recipe for confusion. It's probably too late to do anything about > this for 9.5, but I'd be +1 for adopting Jose's suggestion or some > other formatting tweak in HEAD. I made

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-29 Thread Simon Riggs
On 30 December 2015 at 00:17, Joe Conway wrote: > On 12/29/2015 07:15 AM, Tom Lane wrote: > > Yeah. Use of the same x/y notation with two different bases seems like > > a recipe for confusion. It's probably too late to do anything about > > this for 9.5, but I'd be +1 for

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-29 Thread José Luis Tallón
On 12/29/2015 01:18 PM, Heikki Linnakangas wrote: On 29/12/15 07:14, Joe Conway wrote: I wonder why "Latest checkpoint's NextXID" is formated like this: 8<- printf(_("Latest checkpoint's NextXID: %u/%u\n"),

Re: [HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-29 Thread Heikki Linnakangas
On 29/12/15 07:14, Joe Conway wrote: I wonder why "Latest checkpoint's NextXID" is formated like this: 8<- printf(_("Latest checkpoint's NextXID: %u/%u\n"), ControlFile.checkPointCopy.nextXidEpoch,

[HACKERS] pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

2015-12-28 Thread Joe Conway
I wonder why "Latest checkpoint's NextXID" is formated like this: 8<- printf(_("Latest checkpoint's NextXID: %u/%u\n"), ControlFile.checkPointCopy.nextXidEpoch, ControlFile.checkPointCopy.nextXid);