Re: [HACKERS] pg_dump COMMENT ON DATABASE sometimes inappropriate

2005-09-21 Thread Robert Treat
On Wednesday 21 September 2005 01:10, Michael Fuhr wrote: pg_dump emits COMMENT ON DATABASE (if the database has a comment) even when dumping only an individual schema or table. That seems inappropriate, especially when copying data to a different cluster where the named database might not

Re: [HACKERS] pg_dump COMMENT ON DATABASE sometimes inappropriate

2005-09-21 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: pg_dump emits COMMENT ON DATABASE (if the database has a comment) even when dumping only an individual schema or table. That seems inappropriate, Agreed, this seems like a bug. Fix applied. regards, tom lane

[HACKERS] pg_dump COMMENT ON DATABASE sometimes inappropriate

2005-09-20 Thread Michael Fuhr
pg_dump emits COMMENT ON DATABASE (if the database has a comment) even when dumping only an individual schema or table. That seems inappropriate, especially when copying data to a different cluster where the named database might not exist or might have a different comment that shouldn't be

Re: [HACKERS] pg_dump --comment?

2004-06-01 Thread Harald Fuchs
In article [EMAIL PROTECTED], Chris Campbell [EMAIL PROTECTED] writes: Harald Fuchs wrote: Why don't you just do ( echo -- This is my comment pg_dump whatever ) dumpfile ? How could I dump using the custom format, and then use dumpfile with pg_restore to restore the dump? If I just

Re: [HACKERS] pg_dump --comment?

2004-05-31 Thread Jan Wieck
This can be accomplished with 10-20 lines of shell scripting. I don't think it's worth the trouble bloating pg_dump with it at all. Jan On 5/27/2004 10:10 PM, Chris Campbell wrote: I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For

Re: [HACKERS] pg_dump --comment?

2004-05-31 Thread Bruce Momjian
Jan Wieck wrote: This can be accomplished with 10-20 lines of shell scripting. I don't think it's worth the trouble bloating pg_dump with it at all. Considering how much bloat -v adds, adding a datestamp to it is trivial. -v outputs things like: -- -- TOC entry 1449

Re: [HACKERS] pg_dump --comment?

2004-05-31 Thread Chris Campbell
Harald Fuchs wrote: Why don't you just do ( echo -- This is my comment pg_dump whatever ) dumpfile ? How could I dump using the custom format, and then use dumpfile with pg_restore to restore the dump? If I just prepend the comment to the file, then pg_restore will choke, since the file

Re: [HACKERS] pg_dump --comment?

2004-05-28 Thread Jon Jensen
On Fri, 28 May 2004, Christopher Kings-Lynne wrote: I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For instance, the timestamp of the dump. And some other information that I pull from the database. I think every dump should

Re: [HACKERS] pg_dump --comment?

2004-05-28 Thread Andrew Dunstan
Jon Jensen wrote: On Fri, 28 May 2004, Christopher Kings-Lynne wrote: I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For instance, the timestamp of the dump. And some other information that I pull from the database. I think

Re: [HACKERS] pg_dump --comment?

2004-05-28 Thread James Robinson
On May 28, 2004, at 10:48 AM, Andrew Dunstan wrote: A better answer to this particular problem might be incremental dumps, though :-) Oh would incremental dumps be ever so hungrily accepted by ever so many shops. I had imagined that PITR transaction log archiving would allow one to perform an

[HACKERS] pg_dump --comment?

2004-05-27 Thread Chris Campbell
I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For instance, the timestamp of the dump. And some other information that I pull from the database. If pg_dump had a --comment flag that allowed me to pass a string that would be stored

Re: [HACKERS] pg_dump --comment?

2004-05-27 Thread Christopher Kings-Lynne
I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For instance, the timestamp of the dump. And some other information that I pull from the database. I think every dump should dump the timestamp regardless... Chris