Re: [HACKERS] pg_dump -X

2011-03-18 Thread Robert Haas
On Mon, Mar 14, 2011 at 9:56 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Mar 12, 2011 at 12:56 AM, Bruce Momjian br...@momjian.us wrote: Presumably the point of deprecating the feature is that we'd eventually remove it.  If 4 major releases isn't long enough, what is? Good point.

Re: [HACKERS] pg_dump -X

2011-03-14 Thread Robert Haas
On Sat, Mar 12, 2011 at 12:56 AM, Bruce Momjian br...@momjian.us wrote: Presumably the point of deprecating the feature is that we'd eventually remove it.  If 4 major releases isn't long enough, what is? Good point. Unless there are further objections, I think we should go ahead and remove

Re: [HACKERS] pg_dump -X

2011-03-12 Thread Aaron W. Swenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/24/2010 02:32 AM, J. Roeleveld wrote: Also, unless Gentoo actually strips the man-page and --help page (which I do seriously doubt), I do not see the -X option in the documentation. -- Joost Delayed response: No, we don't strip

Re: [HACKERS] pg_dump -X

2011-03-11 Thread David Fetter
On Thu, Mar 10, 2011 at 10:46:47PM -0500, Robert Haas wrote: On Thu, Mar 10, 2011 at 10:36 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date:  

Re: [HACKERS] pg_dump -X

2011-03-11 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie mar 11 00:59:03 -0300 2011: At a minimum, we should probably also remove -X no-security-label and -X no-unlogged-table-data, which don't exist in any released versions (unless you want to count alphas). But considering that this has been

Re: [HACKERS] pg_dump -X

2011-03-11 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie mar 11 00:59:03 -0300 2011: At a minimum, we should probably also remove -X no-security-label and -X no-unlogged-table-data, which don't exist in any released versions (unless you want to count alphas). But considering

Re: [HACKERS] pg_dump -X

2011-03-11 Thread Robert Haas
On Fri, Mar 11, 2011 at 10:36 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie mar 11 00:59:03 -0300 2011: At a minimum, we should probably also remove -X no-security-label and -X no-unlogged-table-data, which don't exist in any

Re: [HACKERS] pg_dump -X

2011-03-11 Thread Bruce Momjian
Robert Haas wrote: On Fri, Mar 11, 2011 at 10:36 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie mar 11 00:59:03 -0300 2011: At a minimum, we should probably also remove -X no-security-label and -X no-unlogged-table-data,

Re: [HACKERS] pg_dump -X

2011-03-10 Thread Robert Haas
On Thu, Mar 10, 2011 at 10:36 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date:   Sat Oct 7 20:59:05 2006 +     The -X option in pg_dump was

Re: [HACKERS] pg_dump -X

2011-03-10 Thread Bruce Momjian
Robert Haas wrote: Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date: Sat Oct 7 20:59:05 2006 + The -X option in pg_dump was supposed to be a workaround for the lack of portable long options.

Re: [HACKERS] pg_dump -X

2011-03-10 Thread Bruce Momjian
Robert Haas wrote: On Thu, Mar 10, 2011 at 10:36 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date: ? Sat Oct 7 20:59:05 2006 + ? ? The

Re: [HACKERS] pg_dump -X

2010-12-24 Thread Kevin Grittner
Robert Haas wrote: The existing comment says that -X is deprecated, but that doesn't make it entirely 100% clear that the code isn't intended to be further updated Yeah, Dan recently implemented the DEFERRABLE transaction behavior which was discussed on the list, so I added a

[HACKERS] pg_dump -X

2010-12-23 Thread Robert Haas
Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date: Sat Oct 7 20:59:05 2006 + The -X option in pg_dump was supposed to be a workaround for the lack of portable long options. But we have had portable long

Re: [HACKERS] pg_dump -X

2010-12-23 Thread J. Roeleveld
On Friday 24 December 2010 05:35:26 Robert Haas wrote: Back in 2006, we have this commit: commit 2b25e1169f44368c120931787628d51731b5cc8c Author: Peter Eisentraut pete...@gmx.net Date: Sat Oct 7 20:59:05 2006 + The -X option in pg_dump was supposed to be a workaround for the