Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-09-30 Thread Pavel Stehule
2014-09-30 17:18 GMT+02:00 Alvaro Herrera : > > I have pushed this fix, except that instead of parsing the OID from the > dropStmt as in your patch, I used te->catalogId.oid, which is much > simpler. > yes, it is much better > > I tested this by pg_restoring to 8.4 (which doesn't have > pg_larg

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-09-30 Thread Alvaro Herrera
I have pushed this fix, except that instead of parsing the OID from the dropStmt as in your patch, I used te->catalogId.oid, which is much simpler. I tested this by pg_restoring to 8.4 (which doesn't have pg_largeobject_metadata); there is no error raised: LOG: sentencia: SELECT CASE WHEN EXIST

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-09-24 Thread Alvaro Herrera
Heikki Linnakangas wrote: > On 09/24/2014 01:50 PM, Thom Brown wrote: > >>I am sending two patches > >> > >>first is fast fix > >> > >>second fix is implementation of Heikki' idea. > > > >I'm guessing this issue is still unresolved? It would be nice to get this > >off the open items list. > > Ye

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-09-24 Thread Heikki Linnakangas
On 09/24/2014 01:50 PM, Thom Brown wrote: On 15 August 2014 16:31, Pavel Stehule wrote: 2014-08-14 9:03 GMT+02:00 Heikki Linnakangas : On 08/14/2014 06:53 AM, Joachim Wieland wrote: I'm seeing an assertion failure with "pg_dump -c --if-exists" which is not ready to handle BLOBs it seems:

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-09-24 Thread Thom Brown
On 15 August 2014 16:31, Pavel Stehule wrote: > Hi > > > 2014-08-14 9:03 GMT+02:00 Heikki Linnakangas : > >> On 08/14/2014 06:53 AM, Joachim Wieland wrote: >> >>> I'm seeing an assertion failure with "pg_dump -c --if-exists" which is >>> not ready to handle BLOBs it seems: >>> >>> pg_dump: pg_bac

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-15 Thread David Fetter
On Thu, Aug 14, 2014 at 10:03:57AM +0300, Heikki Linnakangas wrote: > On 08/14/2014 06:53 AM, Joachim Wieland wrote: > >I'm seeing an assertion failure with "pg_dump -c --if-exists" which is > >not ready to handle BLOBs it seems: > > > >pg_dump: pg_backup_archiver.c:472: RestoreArchive: Assertion `

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-15 Thread Pavel Stehule
Hi 2014-08-14 9:03 GMT+02:00 Heikki Linnakangas : > On 08/14/2014 06:53 AM, Joachim Wieland wrote: > >> I'm seeing an assertion failure with "pg_dump -c --if-exists" which is >> not ready to handle BLOBs it seems: >> >> pg_dump: pg_backup_archiver.c:472: RestoreArchive: Assertion `mark != >> ((v

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-14 Thread Alvaro Herrera
Heikki Linnakangas wrote: > The quick fix would be to add an exception for blobs, close to where > Assert is. There are a few exceptions there already. A cleaner > solution would be to add a new argument to ArchiveEntry and make the > callers responsible for providing an "DROP IF EXISTS" query, bu

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-14 Thread Pavel Stehule
2014-08-14 15:11 GMT+02:00 Alvaro Herrera : > Heikki Linnakangas wrote: > > On 08/14/2014 06:53 AM, Joachim Wieland wrote: > > >I'm seeing an assertion failure with "pg_dump -c --if-exists" which is > > >not ready to handle BLOBs it seems: > > > > > >pg_dump: pg_backup_archiver.c:472: RestoreArchi

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-14 Thread Alvaro Herrera
Heikki Linnakangas wrote: > On 08/14/2014 06:53 AM, Joachim Wieland wrote: > >I'm seeing an assertion failure with "pg_dump -c --if-exists" which is > >not ready to handle BLOBs it seems: > > > >pg_dump: pg_backup_archiver.c:472: RestoreArchive: Assertion `mark != > >((void *)0)' failed. > > > >To

Re: [HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-14 Thread Heikki Linnakangas
On 08/14/2014 06:53 AM, Joachim Wieland wrote: I'm seeing an assertion failure with "pg_dump -c --if-exists" which is not ready to handle BLOBs it seems: pg_dump: pg_backup_archiver.c:472: RestoreArchive: Assertion `mark != ((void *)0)' failed. To reproduce: $ createdb test $ pg_dump -c --if-e

[HACKERS] pg_dump bug in 9.4beta2 and HEAD

2014-08-13 Thread Joachim Wieland
I'm seeing an assertion failure with "pg_dump -c --if-exists" which is not ready to handle BLOBs it seems: pg_dump: pg_backup_archiver.c:472: RestoreArchive: Assertion `mark != ((void *)0)' failed. To reproduce: $ createdb test $ pg_dump -c --if-exists test (works, dumps empty database) $ psql