Re: [HACKERS] pg_dump fails on domain constraint comments

2016-01-23 Thread Elvis Pranskevichus
On January 22, 2016 08:09:36 PM Alvaro Herrera wrote: > Michael Paquier wrote: > > On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus wrote: > > > It looks like pg_dump emits incorrect text for domain constraint > > > comments: > > > > > > Assuming the following structure,

Re: [HACKERS] pg_dump fails on domain constraint comments

2016-01-22 Thread Alvaro Herrera
Michael Paquier wrote: > On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus > wrote: > > It looks like pg_dump emits incorrect text for domain constraint comments: > > > > Assuming the following structure, > > Nice catch! qtypname already has fmtId applied to it, so quotes

Re: [HACKERS] pg_dump fails on domain constraint comments

2016-01-16 Thread Michael Paquier
On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus wrote: > It looks like pg_dump emits incorrect text for domain constraint comments: > > Assuming the following structure, Nice catch! qtypname already has fmtId applied to it, so quotes are applied twice to it in this case.

[HACKERS] pg_dump fails on domain constraint comments

2016-01-11 Thread Elvis Pranskevichus
Hello Alvaro, It looks like pg_dump emits incorrect text for domain constraint comments: Assuming the following structure, CREATE DOMAIN "dom" AS integer CONSTRAINT "dom_constraint" CHECK ((VALUE > 10)); COMMENT ON CONSTRAINT "dom_constraint" ON DOMAIN "dom" IS 'domain constraint