David Rowley writes:
> The tailing white space is fixed in the attached patch.
Applied with minor cosmetic adjustments.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.o
On Sat, Nov 16, 2013 at 9:04 AM, Peter Eisentraut wrote:
> src/bin/pg_dump/pg_dump.c:1604: trailing whitespace.
> + staticStmt = createPQExpBuffer();
> src/bin/pg_dump/pg_dump.c:1612: trailing whitespace.
> + else
> src/bin/pg_dump/pg_du
src/bin/pg_dump/pg_dump.c:1604: trailing whitespace.
+ staticStmt = createPQExpBuffer();
src/bin/pg_dump/pg_dump.c:1612: trailing whitespace.
+ else
src/bin/pg_dump/pg_dump.c:1614: trailing whitespace.
+
On Sat, Oct 5, 2013 at 6:39 AM, Stephen Frost wrote:
> * Robert Haas (robertmh...@gmail.com) wrote:
> > On Fri, Oct 4, 2013 at 11:28 AM, Tom Lane wrote:
> > > David Rowley writes:
> > >> Here's a small patch which greatly increases the speed of
> > >> pg_dump --column-inserts.
> > >
> > > The r
* Robert Haas (robertmh...@gmail.com) wrote:
> On Fri, Oct 4, 2013 at 11:28 AM, Tom Lane wrote:
> > David Rowley writes:
> >> Here's a small patch which greatly increases the speed of
> >> pg_dump --column-inserts.
> >
> > The reason why no one's paid any attention to the speed of that code path
On Fri, Oct 4, 2013 at 11:28 AM, Tom Lane wrote:
> David Rowley writes:
>> Here's a small patch which greatly increases the speed of
>> pg_dump --column-inserts.
>
> The reason why no one's paid any attention to the speed of that code path
> is that if you care about dump/restore speed, you shoul
David Rowley writes:
> Here's a small patch which greatly increases the speed of
> pg_dump --column-inserts.
The reason why no one's paid any attention to the speed of that code path
is that if you care about dump/restore speed, you should be using the COPY
code paths instead. Is it really worth
Here's a small patch which greatly increases the speed of
pg_dump --column-inserts.
Previous to this patch a string was being build for the names of the
columns for each row in the table... I've now changed this to only do this
once for the table.
I also did some clean ups to remove calling the v
