Re: [HACKERS] pg_get_indexdef() doesn't quote string reloptions

2014-10-14 Thread Eric B. Ridge
> If this communication is in fact intended to be protected by some > legal privilege, or to remain company confidential, you have > definitely sent it to the wrong place. Sadly I don't control my company's email server. They however don't control my gmail account. I'll switch to that. eri

Re: [HACKERS] pg_get_indexdef() doesn't quote string reloptions

2014-10-13 Thread Michael Paquier
On Tue, Oct 14, 2014 at 12:21 AM, Eric Ridge wrote: > pg_get_indexdef() and pg_dump don't quote the reloption values, making a > restore (or cut-n-paste of the pg_get_indexdef() output) impossible if the > reloption value contains non-alphanumerics. > > For example, the statement: > > #

Re: [HACKERS] pg_get_indexdef() doesn't quote string reloptions

2014-10-13 Thread Robert Haas
On Mon, Oct 13, 2014 at 11:21 AM, Eric Ridge wrote: > PROPRIETARY AND COMPANY CONFIDENTIAL COMMUNICATIONS > The information contained in this communication is intended only for > the use of the addressee. Any other use is strictly prohibited. > Please notify the sender if you have received this me

[HACKERS] pg_get_indexdef() doesn't quote string reloptions

2014-10-13 Thread Eric Ridge
Hi all! I've been working on implementing a custom index using the Index Access Method API and have the need for custom reloptions that are "complex" strings (ie, also contain non-alphaumerics). pg_get_indexdef() and pg_dump don't quote the reloption values, making a restore (or cut-n-paste of