On Mon, Feb 19, 2007 at 11:18:36AM -0500, Tom Lane wrote:
Magnus, I'd suggest reverting whatever you did to your MSVC script,
so we'll find out the next time someone makes this mistake...
Reverted. I left the part in genbki.pl in there, because that's a plain
bug that was exposed by this,
On Mon, Feb 19, 2007 at 11:18:36AM -0500, Tom Lane wrote:
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 16:50 schrieb Tom Lane:
In the second place, if you don't want to predetermine OIDs for your
functions then they shouldn't be in hardwired pg_proc.h rows at all.
Am Dienstag, 20. Februar 2007 09:24 schrieb Magnus Hagander:
Ok. Will do once the entires in pg_proc are changed, so that I can still
build.
It's done.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broadcast)---
TIP 5:
I notice that this patch:
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h.diff?r1=1.443r2=1.444
inserts a bunch of XML related rows in pg_proc without specifying oid.
This breaks the fmgrtab generator on msvc. Most likely because I didn't
think of that case. But
Am Montag, 19. Februar 2007 10:16 schrieb Magnus Hagander:
This breaks the fmgrtab generator on msvc. Most likely because I didn't
think of that case. But since all other rows in pg_proc.h contain the
oid, I just wanted to check if they're actually supposed to be withuot
oid, or if that was a
On Mon, Feb 19, 2007 at 11:25:02AM +0100, Peter Eisentraut wrote:
Am Montag, 19. Februar 2007 10:16 schrieb Magnus Hagander:
This breaks the fmgrtab generator on msvc. Most likely because I didn't
think of that case. But since all other rows in pg_proc.h contain the
oid, I just wanted to
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 10:16 schrieb Magnus Hagander:
This breaks the fmgrtab generator on msvc. Most likely because I didn't
think of that case. But since all other rows in pg_proc.h contain the
oid, I just wanted to check if they're actually
Am Montag, 19. Februar 2007 16:26 schrieb Tom Lane:
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 10:16 schrieb Magnus Hagander:
This breaks the fmgrtab generator on msvc. Most likely because I didn't
think of that case. But since all other rows in pg_proc.h contain
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 16:26 schrieb Tom Lane:
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 10:16 schrieb Magnus Hagander:
This breaks the fmgrtab generator on msvc.
It's intentional.
Kindly change that intention.
Tom Lane [EMAIL PROTECTED] writes:
In the second place, if you don't want to predetermine OIDs for your
functions then they shouldn't be in hardwired pg_proc.h rows at all.
Is there any place to hook in to create things like procedures or other SQL
objects that don't really need hard coded
Am Montag, 19. Februar 2007 16:50 schrieb Tom Lane:
Well, in the first place Gen_fmgrtab.sh is producing garbage:
Uh, ok, that needs fixing.
In the second place, if you don't want to predetermine OIDs for your
functions then they shouldn't be in hardwired pg_proc.h rows at all.
Where else
Peter Eisentraut [EMAIL PROTECTED] writes:
Am Montag, 19. Februar 2007 16:50 schrieb Tom Lane:
In the second place, if you don't want to predetermine OIDs for your
functions then they shouldn't be in hardwired pg_proc.h rows at all.
Where else would you put them?
SQL script maybe, much along
Peter Eisentraut wrote:
Am Montag, 19. Februar 2007 16:50 schrieb Tom Lane:
Well, in the first place Gen_fmgrtab.sh is producing garbage:
Uh, ok, that needs fixing.
In the second place, if you don't want to predetermine OIDs for your
functions then they shouldn't be in hardwired
Tom Lane wrote:
SQL script maybe, much along the lines Greg was just mentioning.
I would welcome that, although a similar suggestion was rejected a few
years ago, which is why I didn't pursue it here.
you can't just decide to leave out a few OIDs on the
spur of the moment.
I still don't
14 matches
Mail list logo
