Re: [HACKERS] pg_proc.probin should become text?

2009-08-04 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: I agree, so information about patch would be store in text field. But I am not sure, if your fix isn't too simply. I haven't plan to compile plpgsql to C or to binary code. But could be interesting link postgres with some virtual machine like

Re: [HACKERS] pg_proc.probin should become text?

2009-08-04 Thread Alvaro Herrera
Pavel Stehule escribió: I agree, so information about patch would be store in text field. But I am not sure, if your fix isn't too simply. I haven't plan to compile plpgsql to C or to binary code. But could be interesting link postgres with some virtual machine like parrot or lua vm, and

Re: [HACKERS] pg_proc.probin should become text?

2009-08-04 Thread Pavel Stehule
2009/8/4 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I agree, so information about patch would be store in text field. But I am not sure, if your fix isn't too simply. I haven't plan to compile plpgsql to C or to binary code. But could be interesting link

[HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Tom Lane
pg_proc.probin is currently declared as being type bytea. Perhaps that had some real utility once upon a time, but no currently defined procedural language stores binary data there. In fact, the only thing that gets stored there is the shared-library file name for C functions. To make things

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Robert Haas
On Mon, Aug 3, 2009 at 10:03 PM, Tom Lanet...@sss.pgh.pa.us wrote: pg_proc.probin is currently declared as being type bytea.  Perhaps that had some real utility once upon a time, but no currently defined procedural language stores binary data there.  In fact, the only thing that gets stored

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Aug 3, 2009 at 10:03 PM, Tom Lanet...@sss.pgh.pa.us wrote: I think that the least painful solution might be to change pg_proc.probin to be declared as text.  Otherwise we're going to need version-specific klugery in pg_dump and who knows where

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread David Fetter
On Mon, Aug 03, 2009 at 10:03:11PM -0400, Tom Lane wrote: However, with the hex bytea output patch in place, it's *completely* broken. I offer the following pg_dump output: CREATE FUNCTION interpt_pp(path, path) RETURNS point LANGUAGE c AS

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Robert Haas
On Mon, Aug 3, 2009 at 10:40 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Aug 3, 2009 at 10:03 PM, Tom Lanet...@sss.pgh.pa.us wrote: I think that the least painful solution might be to change pg_proc.probin to be declared as text.  Otherwise we're

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Pavel Stehule
2009/8/4 Tom Lane t...@sss.pgh.pa.us: pg_proc.probin is currently declared as being type bytea.  Perhaps that had some real utility once upon a time, but no currently defined procedural language stores binary data there.  In fact, the only thing that gets stored there is the shared-library

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: 2009/8/4 Tom Lane t...@sss.pgh.pa.us: I think that the least painful solution might be to change pg_proc.probin to be declared as text. correct solution is moving the path to prosrc col or create new colum externalproc. I thing so probin should

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Pavel Stehule
2009/8/4 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: 2009/8/4 Tom Lane t...@sss.pgh.pa.us: I think that the least painful solution might be to change pg_proc.probin to be declared as text. correct solution is moving the path to prosrc col or create new colum

Re: [HACKERS] pg_proc.probin should become text?

2009-08-03 Thread Pavel Stehule
2009/8/4 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: 2009/8/4 Tom Lane t...@sss.pgh.pa.us: I think that the least painful solution might be to change pg_proc.probin to be declared as text. correct solution is moving the path to prosrc col or create new colum