Re: [HACKERS] pg_restore --clean vs. large object

2009-07-21 Thread Tom Lane
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: Jaime Casanova jcasa...@systemguards.com.ec wrote: i think this one could be applied, just as is... there is no need for docs, because the issue being fixed is not documented... maybe that should be in doc of older releases? Sure, it

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-21 Thread Tom Lane
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: The attached is a patch to execute lo_unlink() before lo_create() in pg_restore. Applied with corrections --- you had failed to ensure that pg_dump and pg_restore produce the same output. I also took the opportunity to schema-qualify the

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-20 Thread Itagaki Takahiro
Jaime Casanova jcasa...@systemguards.com.ec wrote: i think this one could be applied, just as is... there is no need for docs, because the issue being fixed is not documented... maybe that should be in doc of older releases? Sure, it was an undocumented behavior. Should we need to add

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-18 Thread Jaime Casanova
On Mon, May 18, 2009 at 3:10 AM, Itagaki Takahiroitagaki.takah...@oss.ntt.co.jp wrote: The attached is a patch to execute lo_unlink() before lo_create() in pg_restore. the patch applies almost cleanly (there are only minor and superfluos hunks), compiles... it works as expected... this patch

[HACKERS] pg_restore --clean vs. large object

2009-05-18 Thread Itagaki Takahiro
Hi, Since pg_restore --clean doesn't delete existing large objects, restoring to an existing database with pg_restore --clean -1 would fail if backup archive contains large objects. Some DBAs complain to the behavior because they expect all existing data conflicting with backup archive will be