Re: [HACKERS] pg_stat_statements vs escape_string_warning

2015-01-21 Thread Tom Lane
Peter Geoghegan writes: > On Wed, Jan 21, 2015 at 10:14 AM, Tom Lane wrote: >> This isn't a back-patchable bug fix, but given the lack of prior >> complaints, maybe it doesn't matter. Alternatively, we could back-patch >> only the addition of escape_string_warning to the struct: that would fit >

Re: [HACKERS] pg_stat_statements vs escape_string_warning

2015-01-21 Thread Peter Geoghegan
On Wed, Jan 21, 2015 at 10:14 AM, Tom Lane wrote: > What I'm inclined to do about this is add an escape_string_warning bool > field to struct core_yy_extra_type, which would be copied from the GUC > variable by scanner_init(); then check_string_escape_warning() would > consult that field instead o

[HACKERS] pg_stat_statements vs escape_string_warning

2015-01-21 Thread Tom Lane
I happened to notice that if you run the regression tests with pg_stat_statements installed, you will often (not always) get a failure that looks like this: *** src/test/regress/expected/plpgsql.out Tue Jan 20 12:01:52 2015 --- src/test/regress/results/plpgsql.out Wed Jan 21 12:43:19 2015