Re: [HACKERS] pgbench --tuple-size option

2014-08-16 Thread Fabien COELHO
The custom initialization is to run a manual ALTER after the initialization. Sure, it can be done this way. I'm not sure about the implication of ALTER on the table storage, Should be fine in this case. After some testing and laughing, my conclusion is "not fine at all". The "filler" att

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fabien COELHO
Hmmm. This would mean much more changes than the pretty trivial patch I submitted FWIW, I find that patch really ugly. Adding the filler's with in a printf, after the actual DDL declaration. Without so much as a comment. Brr. Indeed. I'm not too proud of that very point either:-) You are rig

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fujii Masao
On Fri, Aug 15, 2014 at 8:36 PM, Andres Freund wrote: > On 2014-08-15 13:33:20 +0200, Fabien COELHO wrote: >> >it seems to make more sense to split -i into two. One to create the >> >tables, and another to fill them. That'd allow to do manual stuff >> >inbetween. >> >> Hmmm. This would mean much m

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Andres Freund
On 2014-08-15 13:33:20 +0200, Fabien COELHO wrote: > >it seems to make more sense to split -i into two. One to create the > >tables, and another to fill them. That'd allow to do manual stuff > >inbetween. > > Hmmm. This would mean much more changes than the pretty trivial patch I > submitted FWIW

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fabien COELHO
I'm not sure about the implication of ALTER on the table storage, Should be fine in this case. But if that's what you're concerned about - understandably - Indeed, my (long) experience with benchmarks is that it is a much more complicated that it looks if you want to really understand what

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Andres Freund
On 2014-08-15 12:17:31 +0200, Fabien COELHO wrote: > > >>>I don't think it's beneficial to put this into pgbench. There really > >>>isn't a relevant benefit over using a custom script here. > >> > >>The scripts to run are the standard ones. The difference is in the > >>*initialization* phase (-i),

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fabien COELHO
I don't think it's beneficial to put this into pgbench. There really isn't a relevant benefit over using a custom script here. The scripts to run are the standard ones. The difference is in the *initialization* phase (-i), namely the filler attribute size. There is no custom script for initial

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Andres Freund
On 2014-08-15 11:58:41 +0200, Fabien COELHO wrote: > > Hello Andres, > > >>This patch adds an option to change the default tuple size, so that this can > >>be tested easily. > > > >I don't think it's beneficial to put this into pgbench. There really > >isn't a relevant benefit over using a custom

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fabien COELHO
Hello Andres, This patch adds an option to change the default tuple size, so that this can be tested easily. I don't think it's beneficial to put this into pgbench. There really isn't a relevant benefit over using a custom script here. The scripts to run are the standard ones. The differenc

Re: [HACKERS] pgbench --tuple-size option

2014-08-15 Thread Andres Freund
On 2014-08-15 11:46:52 +0200, Fabien COELHO wrote: > > After publishing some test results with pgbench on SSD with varying page > size, Josh Berkus pointed out that pgbench uses small 100-bytes tuples, and > that results may be different with other tuple sizes. > > This patch adds an option to ch

[HACKERS] pgbench --tuple-size option

2014-08-15 Thread Fabien COELHO
After publishing some test results with pgbench on SSD with varying page size, Josh Berkus pointed out that pgbench uses small 100-bytes tuples, and that results may be different with other tuple sizes. This patch adds an option to change the default tuple size, so that this can be tested ea