Re: [HACKERS] pgbench with large scale factor

2013-12-12 Thread Tatsuo Ishii
> Fabien, > >>> Included is a proposed fix for this (also fixing weired "remaining" >>> part). If there's no objection, I will commit it. >> >> Looks ok, but I would consider switching to "double" instead of >> "int64". > > Assuming you are talking about "remaining sec" part, I agree. Here is >

Re: [HACKERS] pgbench with large scale factor

2013-12-11 Thread Tatsuo Ishii
Fabien, >> Included is a proposed fix for this (also fixing weired "remaining" >> part). If there's no objection, I will commit it. > > Looks ok, but I would consider switching to "double" instead of > "int64". Assuming you are talking about "remaining sec" part, I agree. Here is the revised pat

Re: [HACKERS] pgbench with large scale factor

2013-12-11 Thread Fabien COELHO
Hello Tatsuo, BTW, I saw this with 9.3.2's pgbench: 23930 of 38 tuples (-48%) done (elapsed 226.86 s, remaining -696.10 s). -48% does not seem to be quite correct to me... Included is a proposed fix for this (also fixing weired "remaining" part). If there's no objection, I will

Re: [HACKERS] pgbench with large scale factor

2013-12-11 Thread Tatsuo Ishii
> BTW, I saw this with 9.3.2's pgbench: > > 23930 of 38 tuples (-48%) done (elapsed 226.86 s, remaining > -696.10 s). > > -48% does not seem to be quite correct to me... Included is a proposed fix for this (also fixing weired "remaining" part). If there's no objection, I will commit

Re: [HACKERS] pgbench with large scale factor

2013-12-11 Thread Tatsuo Ishii
>> I noticed that "pgbench -s scale_factor" where scale_factor is larger >> than 20,000 (SCALE_32BIT_THRESHOLD) creates pgbench_accounts table containing >> 0 row without any complain. Is there any reason for this? > > Oops. It appeared that this was a bug prior 9.3 pgbench. Sorry for noise. BTW,

Re: [HACKERS] pgbench with large scale factor

2013-12-11 Thread Tatsuo Ishii
> I noticed that "pgbench -s scale_factor" where scale_factor is larger > than 20,000 (SCALE_32BIT_THRESHOLD) creates pgbench_accounts table containing > 0 row without any complain. Is there any reason for this? Oops. It appeared that this was a bug prior 9.3 pgbench. Sorry for noise. Best regard

[HACKERS] pgbench with large scale factor

2013-12-11 Thread Tatsuo Ishii
I noticed that "pgbench -s scale_factor" where scale_factor is larger than 20,000 (SCALE_32BIT_THRESHOLD) creates pgbench_accounts table containing 0 row without any complain. Is there any reason for this? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.