Re: [HACKERS] pl/python SPI in subtransactions

2011-02-02 Thread Peter Eisentraut
You mentioned that you were going to add a few paragraphs to the documentation saying that you can now actually catch SPI errors. I haven't seen that yet. Yeah, I'm procrastinating the doc writing part ;) Will spit something out by the end of the (CET) day. Done, added a small

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-30 Thread Jan Urbański
On 29/01/11 22:13, Jan Urbański wrote: On 29/01/11 22:10, Steve Singer wrote: On 11-01-29 03:39 PM, Jan Urbański wrote: D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now in master your example with plpy.prepare will result in savepoint being swallowed, but it's of

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-30 Thread Jan Urbański
On 31/01/11 00:03, Jan Urbański wrote: On 29/01/11 22:13, Jan Urbański wrote: On 29/01/11 22:10, Steve Singer wrote: On 11-01-29 03:39 PM, Jan Urbański wrote: D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now in master your example with plpy.prepare will result in

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Steve Singer
On 11-01-27 04:33 PM, Jan Urbański wrote: Right, without the patch you can never catch errors originating from plpy.execute, so any error terminates the whole function, and so rolls back the statement. FWIW PL/Perl works the same: begin; create table foo(i int primary key); DO $$

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Jan Urbański
On 29/01/11 21:27, Steve Singer wrote: On 11-01-27 04:33 PM, Jan Urbański wrote: I am finding the treatment of savepoints very strange. If as a function author I'm able to recover from errors then I'd expect (or maybe want) to be able to manage them through savepoints Ooops, you found a bug

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Steve Singer
On 11-01-29 03:39 PM, Jan Urbański wrote: D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now in master your example with plpy.prepare will result in savepoint being swallowed, but it's of course better to react with an error. Cheers, Jan This seems to fix it. You

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-29 Thread Jan Urbański
On 29/01/11 22:10, Steve Singer wrote: On 11-01-29 03:39 PM, Jan Urbański wrote: D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now in master your example with plpy.prepare will result in savepoint being swallowed, but it's of course better to react with an error.

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-27 Thread Jan Urbański
On 26/01/11 04:51, Steve Singer wrote: On 10-12-23 08:45 AM, Jan Urbański wrote: I see you've merged the changes from the refactoring branch down but haven't yet posted an updated patch. This review is based on 2f2b4a33bf344058620a5c684d1f2459e505c727 Thanks for the review, I'm attaching an

Re: [HACKERS] pl/python SPI in subtransactions

2011-01-25 Thread Steve Singer
On 10-12-23 08:45 AM, Jan Urbański wrote: Here's a patch implementing a executing SPI in an subtransaction mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the plpython-refactor patch sent eariler. Git branch for this patch:

[HACKERS] pl/python SPI in subtransactions

2010-12-23 Thread Jan Urbański
Here's a patch implementing a executing SPI in an subtransaction mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the plpython-refactor patch sent eariler. Git branch for this patch: