Re: [HACKERS] pl/python quoting functions

2011-02-23 Thread Peter Eisentraut
On ons, 2011-02-23 at 11:26 +0100, Jan Urbański wrote: > One thing: you removed the conditional pfree from PLy_quote_ident, > which makes this function leak memory if the actual quoting took > place, no? Is that leak too small to worry about? Many functions in PostgreSQL leak memory in this way.

Re: [HACKERS] pl/python quoting functions

2011-02-23 Thread Jan Urbański
On 22/02/11 22:48, Peter Eisentraut wrote: > Committed this, with two changes: Changed some things around with the > way const char * is propagated. Just casting it away is not nice. Also > dropped the error tests in the _quote.sql regression test. This > generates three different wordings of e

Re: [HACKERS] pl/python quoting functions

2011-02-22 Thread Peter Eisentraut
Committed this, with two changes: Changed some things around with the way const char * is propagated. Just casting it away is not nice. Also dropped the error tests in the _quote.sql regression test. This generates three different wordings of error messages from Python with 2.6, 3.1, and 3.2, w

Re: [HACKERS] pl/python quoting functions

2011-02-06 Thread Jan Urbański
On 06/02/11 10:54, Jan Urbański wrote: > On 04/02/11 18:10, Hitoshi Harada wrote: >> 2011/1/11 Jan Urbański : >>> Here's a patch that adds a few PL/Python functions for quoting strings. >>> It's an incremental patch on top of the plpython-refactor patch sent in >>> http://archives.postgresql.org/me

Re: [HACKERS] pl/python quoting functions

2011-02-06 Thread Jan Urbański
On 04/02/11 18:10, Hitoshi Harada wrote: > 2011/1/11 Jan Urbański : >> Here's a patch that adds a few PL/Python functions for quoting strings. >> It's an incremental patch on top of the plpython-refactor patch sent in >> http://archives.postgresql.org/message-id/4d135170.3080...@wulczer.org. >> >>

Re: [HACKERS] pl/python quoting functions

2011-02-04 Thread Hitoshi Harada
2011/1/11 Jan Urbański : > Here's a patch that adds a few PL/Python functions for quoting strings. > It's an incremental patch on top of the plpython-refactor patch sent in > http://archives.postgresql.org/message-id/4d135170.3080...@wulczer.org. > > Git branch for this patch: > https://github.com/

[HACKERS] pl/python quoting functions

2011-01-10 Thread Jan Urbański
Here's a patch that adds a few PL/Python functions for quoting strings. It's an incremental patch on top of the plpython-refactor patch sent in http://archives.postgresql.org/message-id/4d135170.3080...@wulczer.org. Git branch for this patch: https://github.com/wulczer/postgres/tree/functions The