Re: [HACKERS] port/thread.c and pthreads

2008-04-22 Thread Magnus Hagander
Bruce Momjian wrote: Magnus Hagander wrote: port/thread.c includes the pthreads header files, and contains a bunch of comments about pthreads - but there seems to be no code related to pthreads at all in the file. Am I missing something completely here? ;-) Uh, those files are

Re: [HACKERS] port/thread.c and pthreads

2008-04-22 Thread Alvaro Herrera
Magnus Hagander wrote: Bruce Momjian wrote: Uh, those files are thread-safe/reentrant versions of libc functions. I don't think they need the pthread.h includes. You want to try removing those includes and see how the buildfarm behaves? Done, let's see what happens... Apparently the

Re: [HACKERS] port/thread.c and pthreads

2008-04-22 Thread Magnus Hagander
Alvaro Herrera wrote: Magnus Hagander wrote: Bruce Momjian wrote: Uh, those files are thread-safe/reentrant versions of libc functions. I don't think they need the pthread.h includes. You want to try removing those includes and see how the buildfarm behaves? Done, let's see

Re: [HACKERS] port/thread.c and pthreads

2008-04-22 Thread Bruce Momjian
Magnus Hagander wrote: Alvaro Herrera wrote: Magnus Hagander wrote: Bruce Momjian wrote: Uh, those files are thread-safe/reentrant versions of libc functions. I don't think they need the pthread.h includes. You want to try removing those includes and see how the buildfarm

[HACKERS] port/thread.c and pthreads

2008-04-21 Thread Magnus Hagander
port/thread.c includes the pthreads header files, and contains a bunch of comments about pthreads - but there seems to be no code related to pthreads at all in the file. Am I missing something completely here? ;-) //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] port/thread.c and pthreads

2008-04-21 Thread Bruce Momjian
Magnus Hagander wrote: port/thread.c includes the pthreads header files, and contains a bunch of comments about pthreads - but there seems to be no code related to pthreads at all in the file. Am I missing something completely here? ;-) Uh, those files are thread-safe/reentrant versions of