Re: [HACKERS] proposal: better support for debugging of overloaded functions

2012-01-31 Thread Heikki Linnakangas
On 27.01.2012 15:48, Pavel Stehule wrote: 2012/1/26 Abhijit Menon-Sen: Updated patch attached. Ready for committer. I found a small issue - there was uninitialized fn_signature for online blocks so I append line function->fn_signature = pstrdup(func_name); to plpgsql_compile_inline(char *proc

Re: [HACKERS] proposal: better support for debugging of overloaded functions

2012-01-26 Thread Abhijit Menon-Sen
At 2011-11-24 17:44:16 +0100, pavel.steh...@gmail.com wrote: > > patch is relative long, but almost all are changes in regress tests. > Changes in plpgsql are 5 lines The change looks good in principle. The patch applies to HEAD with a bit of fuzz and builds fine… but it fails tests, because it's

Re: [HACKERS] proposal: better support for debugging of overloaded functions

2011-11-21 Thread Robert Haas
On Sun, Nov 20, 2011 at 6:16 AM, Pavel Stehule wrote: > Is possible to add GUC variable plpgsql.log_function_signature (maybe > just log_function_signature (for all PL))? I am not sure about GUC > name. > > When this variable is true, then CONTEXT line will contain a qualified > function's signatu

Re: [HACKERS] proposal: better support for debugging of overloaded functions

2011-11-20 Thread Pavel Stehule
2011/11/18 Robert Haas : > On Fri, Nov 18, 2011 at 6:24 AM, Pavel Stehule > wrote: >> CONTEXT:  PL/pgSQL function "assign_rslts" line 50 at assignment (oid: 65903) >> >> \sf+ 65903 > > I'm pretty unenthused by the idea of making OIDs more user-visible > than they already are.  If the message is a

Re: [HACKERS] proposal: better support for debugging of overloaded functions

2011-11-18 Thread Pavel Stehule
2011/11/18 Robert Haas : > On Fri, Nov 18, 2011 at 6:24 AM, Pavel Stehule > wrote: >> CONTEXT:  PL/pgSQL function "assign_rslts" line 50 at assignment (oid: 65903) >> >> \sf+ 65903 > > I'm pretty unenthused by the idea of making OIDs more user-visible > than they already are.  If the message is a

Re: [HACKERS] proposal: better support for debugging of overloaded functions

2011-11-18 Thread Robert Haas
On Fri, Nov 18, 2011 at 6:24 AM, Pavel Stehule wrote: > CONTEXT:  PL/pgSQL function "assign_rslts" line 50 at assignment (oid: 65903) > > \sf+ 65903 I'm pretty unenthused by the idea of making OIDs more user-visible than they already are. If the message is ambiguous, we should include argument t

[HACKERS] proposal: better support for debugging of overloaded functions

2011-11-18 Thread Pavel Stehule
Hello I am missing a some unique identifier in exception info. I would to use it in combination with \sf statement I have a log WARNING: NP_CPS: a cannot to build a RSLT object DETAIL: dsql_text: SELECT * FROM public._npacceptflatfile(order_nr:=to_number('O0032', 'O')::int,sequence