Re: [HACKERS] rename pg_log directory?

2017-03-27 Thread Andreas Karlsson
On 03/27/2017 04:38 PM, Peter Eisentraut wrote: Committed. Thanks! While digging around a bit, I found in release-old.sgml that before PostgreSQL 7.2, pg_clog was called pg_log. Go figure. Yeah, I noticed that too when writing the patch. :) Andreas -- Sent via pgsql-hackers mailing

Re: [HACKERS] rename pg_log directory?

2017-03-27 Thread Peter Eisentraut
On 3/6/17 18:01, Andreas Karlsson wrote: > On 02/27/2017 03:05 PM, Peter Eisentraut wrote: >> How about changing the default for log_directory from 'pg_log' to, say, >> 'log'? > > I have attached a patch which does this. I do not care much about which > name is picked as long as we get rid off

Re: [HACKERS] rename pg_log directory?

2017-03-10 Thread Bruce Momjian
On Fri, Mar 10, 2017 at 11:23:54AM +0100, Andreas Karlsson wrote: > On 03/09/2017 11:25 PM, Bruce Momjian wrote: > >"data" and "base" where chosen because it is a "data-base", but with the > >pg_ prefixes it would be a pg_data_pg_base. ;-) > > Haha, I had not spotted that one despite always

Re: [HACKERS] rename pg_log directory?

2017-03-10 Thread Andreas Karlsson
On 03/09/2017 11:25 PM, Bruce Momjian wrote: "data" and "base" where chosen because it is a "data-base", but with the pg_ prefixes it would be a pg_data_pg_base. ;-) Haha, I had not spotted that one despite always naming my data directory "data" while developing. Fun little tidbit there.

Re: [HACKERS] rename pg_log directory?

2017-03-09 Thread Bruce Momjian
On Tue, Mar 7, 2017 at 12:01:04AM +0100, Andreas Karlsson wrote: > On 02/27/2017 03:05 PM, Peter Eisentraut wrote: > >How about changing the default for log_directory from 'pg_log' to, say, > >'log'? > > I have attached a patch which does this. I do not care much about which name > is picked as

Re: [HACKERS] rename pg_log directory?

2017-03-06 Thread Andreas Karlsson
On 02/27/2017 03:05 PM, Peter Eisentraut wrote: How about changing the default for log_directory from 'pg_log' to, say, 'log'? I have attached a patch which does this. I do not care much about which name is picked as long as we get rid off the "pg_" prefix. Btw, is there a reason for why

Re: [HACKERS] rename pg_log directory?

2017-03-06 Thread Tom Lane
Andreas Karlsson writes: > On 03/01/2017 05:49 AM, Peter Eisentraut wrote: >> On 2/27/17 09:51, Tom Lane wrote: >>> No objection to the basic point, but "log" seems perhaps a little too >>> generic to me. Would something like "server_log" be better? >> Well, "log" is pretty

Re: [HACKERS] rename pg_log directory?

2017-03-06 Thread Andreas Karlsson
On 03/01/2017 05:49 AM, Peter Eisentraut wrote: On 2/27/17 09:51, Tom Lane wrote: No objection to the basic point, but "log" seems perhaps a little too generic to me. Would something like "server_log" be better? Well, "log" is pretty well established. There is /var/log, and if you unpack a,

Re: [HACKERS] rename pg_log directory?

2017-02-28 Thread Peter Eisentraut
On 2/28/17 06:07, Magnus Hagander wrote: > server_log seems like a better choice then I think. So +1 for that. > > In theory cluster_log since it's a "cluster level log", but given how > many people already get confused by the term cluster being used that > way, I think that while maybe

Re: [HACKERS] rename pg_log directory?

2017-02-28 Thread Peter Eisentraut
On 2/27/17 09:51, Tom Lane wrote: > No objection to the basic point, but "log" seems perhaps a little too > generic to me. Would something like "server_log" be better? Well, "log" is pretty well established. There is /var/log, and if you unpack a, say, Kafka or Cassandra distribution, they also

Re: [HACKERS] rename pg_log directory?

2017-02-28 Thread Jorge Solórzano
On Tue, Feb 28, 2017 at 5:07 AM, Magnus Hagander wrote: > > server_log seems like a better choice then I think. So +1 for that. > ​server_log +1 ​ > > In theory cluster_log since it's a "cluster level log", but given how many > people already get confused by the term

Re: [HACKERS] rename pg_log directory?

2017-02-28 Thread Magnus Hagander
On Tue, Feb 28, 2017 at 4:01 AM, Bruce Momjian wrote: > On Mon, Feb 27, 2017 at 09:51:26AM -0500, Tom Lane wrote: > > Peter Eisentraut writes: > > > How about changing the default for log_directory from 'pg_log' to, say, > > > 'log'? > > > > >

Re: [HACKERS] rename pg_log directory?

2017-02-27 Thread Bruce Momjian
On Mon, Feb 27, 2017 at 09:51:26AM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > How about changing the default for log_directory from 'pg_log' to, say, > > 'log'? > > > We have been emphasizing that the prefix "pg_" is for things reserved to > >

Re: [HACKERS] rename pg_log directory?

2017-02-27 Thread Tom Lane
Peter Eisentraut writes: > How about changing the default for log_directory from 'pg_log' to, say, > 'log'? > We have been emphasizing that the prefix "pg_" is for things reserved to > PostgreSQL, whereas the pg_log directory is entirely an arbitrary >

Re: [HACKERS] rename pg_log directory?

2017-02-27 Thread David Fetter
On Mon, Feb 27, 2017 at 09:05:16AM -0500, Peter Eisentraut wrote: > How about changing the default for log_directory from 'pg_log' to, say, > 'log'? +1 A lot of work has already gone into this release to clarify what things are PostgreSQL internals and which ones are not. This will help. Yes,

[HACKERS] rename pg_log directory?

2017-02-27 Thread Peter Eisentraut
How about changing the default for log_directory from 'pg_log' to, say, 'log'? We have been emphasizing that the prefix "pg_" is for things reserved to PostgreSQL, whereas the pg_log directory is entirely an arbitrary user-space name. Also, with a different name, the directory would stand out