Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
(2010/08/17 11:37), Robert Haas wrote: >> I might have a reason why the script need to launch in single-user >> mode, but it is not clear right now, sorry. > > Another point here is that I wonder if we really need to label system > objects at all. Are you applying the same label to all of them?

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread Robert Haas
2010/8/16 KaiGai Kohei : >> I don't really see what the advantage of doing this in single-user >> mode is.  If the overhead of permissions-checking is enough to matter, >> maybe that's a sign we're doing something wrong. >> > Hmm... I guess the overhead is not a significant matter, because the > nu

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
(2010/08/17 10:57), Robert Haas wrote: > 2010/8/16 KaiGai Kohei: >> (2010/08/17 9:52), Robert Haas wrote: >>> 2010/8/16 KaiGai Kohei: (2010/08/16 23:40), Robert Haas wrote: > 2010/8/16 KaiGai Kohei: >> Although nobody paid an attention, it seems to me a problem to be fixed. >>

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread Robert Haas
2010/8/16 KaiGai Kohei : > (2010/08/17 9:52), Robert Haas wrote: >> 2010/8/16 KaiGai Kohei: >>> (2010/08/16 23:40), Robert Haas wrote: 2010/8/16 KaiGai Kohei: > Although nobody paid an attention, it seems to me a problem to be fixed. > > The attached patch fixes the problem using a

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
(2010/08/17 9:52), Robert Haas wrote: > 2010/8/16 KaiGai Kohei: >> (2010/08/16 23:40), Robert Haas wrote: >>> 2010/8/16 KaiGai Kohei: Although nobody paid an attention, it seems to me a problem to be fixed. The attached patch fixes the problem using a simple idea which adds proc

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread Robert Haas
2010/8/16 KaiGai Kohei : > (2010/08/16 23:40), Robert Haas wrote: >> 2010/8/16 KaiGai Kohei: >>> Although nobody paid an attention, it seems to me a problem to be fixed. >>> >>> The attached patch fixes the problem using a simple idea which adds >>> process_shared_preload_libraries() at PostgresMai

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
(2010/08/17 9:02), Itagaki Takahiro wrote: > 2010/8/17 KaiGai Kohei: >> I want to kick this job in single-user mode, not normal processing mode, > > Does an explicit LOAD work in single-user mode? > I think LOAD just after login works as same as it was preloaded, > unless it allocates shared memor

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread Itagaki Takahiro
2010/8/17 KaiGai Kohei : > I want to kick this job in single-user mode, not normal processing mode, Does an explicit LOAD work in single-user mode? I think LOAD just after login works as same as it was preloaded, unless it allocates shared memory. -- Itagaki Takahiro -- Sent via pgsql-hackers

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
(2010/08/16 23:40), Robert Haas wrote: > 2010/8/16 KaiGai Kohei: >> Although nobody paid an attention, it seems to me a problem to be fixed. >> >> The attached patch fixes the problem using a simple idea which adds >> process_shared_preload_libraries() at PostgresMain() when we launched >> it in si

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread Robert Haas
2010/8/16 KaiGai Kohei : > Although nobody paid an attention, it seems to me a problem to be fixed. > > The attached patch fixes the problem using a simple idea which adds > process_shared_preload_libraries() at PostgresMain() when we launched > it in single-user mode. I have no confidence at all

Re: [HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-16 Thread KaiGai Kohei
Although nobody paid an attention, it seems to me a problem to be fixed. The attached patch fixes the problem using a simple idea which adds process_shared_preload_libraries() at PostgresMain() when we launched it in single-user mode. Thanks, (2010/08/05 15:08), KaiGai Kohei wrote: > I found out

[HACKERS] shared_preload_libraries is ignored in single user mode

2010-08-04 Thread KaiGai Kohei
I found out "shared_preload_libraries" setting is ignored when we launch postgres in single user mode. In this case, postgres command is launched with "--single" argument, then the main() directly invokes PostgresMain(); without going through PostmasterMain() which calls process_shared_preload_lib