Re: [HACKERS] some dblink refactoring

2017-03-10 Thread Peter Eisentraut
On 3/8/17 00:10, Tsunakawa, Takayuki wrote: > I changed the status to ready for committer. The patch applied cleanly, > passed the regression test (make installcheck in contrib/dblink/), and the > code looks perfect. > > How about applying the attached small patch for another refactoring?

Re: [HACKERS] some dblink refactoring

2017-03-07 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tsunakawa, > Takayuki > How about applying the attached small patch for another refactoring? This > merely changes makeStringInfo() to initStringInfo() at two sites just other > places in the same

Re: [HACKERS] some dblink refactoring

2017-03-07 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut > Here is a patch to refactor some macro hell in dblink. > > This patch was discussed in the background sessions thread as a prerequisite > for some work there, but I figure I'll

Re: [HACKERS] some dblink refactoring

2017-03-01 Thread Peter Eisentraut
On 2/28/17 22:22, Corey Huinker wrote: > Any chance we can make get_connect_string() a core function or at least > externally accessible? [get_connect_string() gets the connection string for a foreign server] The connection string for a foreign server depends on the nature of the foreign server.

Re: [HACKERS] some dblink refactoring

2017-02-28 Thread Corey Huinker
On Tue, Feb 28, 2017 at 10:09 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > Here is a patch to refactor some macro hell in dblink. > > This patch was discussed in the background sessions thread as a > prerequisite for some work there, but I figure I'll make a separate > thread

[HACKERS] some dblink refactoring

2017-02-28 Thread Peter Eisentraut
Here is a patch to refactor some macro hell in dblink. This patch was discussed in the background sessions thread as a prerequisite for some work there, but I figure I'll make a separate thread for it to give everyone interested in dblink a chance to respond separate from the other thread. --