Re: Missing OOM checks in libpq (was Re: [HACKERS] Replication connection URI?)

2014-11-25 Thread Alex Shulgin
Heikki Linnakangas writes: >>> >>> I think we need to fix all of those, and backpatch. Per attached. >> >> Yikes! Looks sane to me. > > Ok thanks, committed. It didn't apply cleanly to 9.0, 9.1 and 9.2, so > the patch for those branches looks a bit different. Great. Are you looking at the actu

Re: Missing OOM checks in libpq (was Re: [HACKERS] Replication connection URI?)

2014-11-25 Thread Heikki Linnakangas
On 11/25/2014 01:37 PM, Alex Shulgin wrote: Heikki Linnakangas writes: On 11/24/2014 06:05 PM, Alex Shulgin wrote: The first patch is not on topic, I just spotted this missing check. *** a/src/interfaces/libpq/fe-connect.c --- b/src/interfaces/libpq/fe-connect.c *** conninfo_a

Re: Missing OOM checks in libpq (was Re: [HACKERS] Replication connection URI?)

2014-11-25 Thread Alex Shulgin
Heikki Linnakangas writes: > On 11/24/2014 06:05 PM, Alex Shulgin wrote: >> The first patch is not on topic, I just spotted this missing check. > >> *** a/src/interfaces/libpq/fe-connect.c >> --- b/src/interfaces/libpq/fe-connect.c >> *** conninfo_array_parse(const char *const * >> *

Missing OOM checks in libpq (was Re: [HACKERS] Replication connection URI?)

2014-11-25 Thread Heikki Linnakangas
On 11/24/2014 06:05 PM, Alex Shulgin wrote: The first patch is not on topic, I just spotted this missing check. *** a/src/interfaces/libpq/fe-connect.c --- b/src/interfaces/libpq/fe-connect.c *** conninfo_array_parse(const char *const * *** 4402,4407 --- 4402,4415