Re: [HACKERS] [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: ! /* WaitForSingleObjectEx() uses milliseconds */ ! waittime = timerCommArea.value.it_value.tv_usec / 1000 + timerCommArea.value.it_value.tv_sec * 1000; Seems like this probably ought to round up

Re: [HACKERS] [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: ! /* WaitForSingleObjectEx() uses milliseconds */ ! waittime = timerCommArea.value.it_value.tv_usec / 1000 + timerCommArea.value.it_value.tv_sec * 1000; Seems like this probably

Re: [HACKERS] [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Seems like this probably ought to round up not down: I thought about that, but because statement_timeout is in millis, and not micros, we can't have a value that gets rounded down. I am thinking a cleaner solution is to check for secs