On Mon, 2008-12-29 at 15:06 +0900, Fujii Masao wrote:
This seems to have not been fixed yet in the latest patch.
http://archives.postgresql.org/message-id/494ff631.90...@enterprisedb.com
recovery-infra-separated-again-1.patch
I'll add it to my issues-reported list so we can check for
Hi,
On Tue, Nov 18, 2008 at 12:39 AM, Simon Riggs si...@2ndquadrant.com wrote:
On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:
Simon Riggs wrote:
@@ -3845,6 +3850,52 @@ sigusr1_handler(SIGNAL_ARGS)
PG_SETMASK(BlockSig);
+ if
On Mon, 2008-12-22 at 22:18 +0200, Heikki Linnakangas wrote:
I think it's useful to review the infra part of the patch separately,
so I split it out of the big patch again. I haven't looked at this in
detail yet, but it compiles and passes regression tests.
OK, thanks, much appreciated.
On Tue, Dec 23, 2008 at 5:18 AM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
Simon Riggs wrote:
On Wed, 2008-12-17 at 23:32 -0300, Alvaro Herrera wrote:
Simon Riggs escribió:
Please let me know how I can make the reviewer's job easier. Diagrams,
writeups, whatever.
On Thu, 2008-11-20 at 10:10 +, Simon Riggs wrote:
On Thu, 2008-11-20 at 15:19 +0530, Pavan Deolasee wrote:
Do you intend to split the patch into smaller pieces ? The latest hot
standby patch is almost 10K+ lines. Splitting that would definitely
help the review process.
If it helps
Simon Riggs escribió:
Please let me know how I can make the reviewer's job easier. Diagrams,
writeups, whatever. Thanks,
A link perhaps?
--
Alvaro Herrerahttp://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
--
Sent via pgsql-hackers
On Wed, 2008-12-17 at 23:32 -0300, Alvaro Herrera wrote:
Simon Riggs escribió:
Please let me know how I can make the reviewer's job easier. Diagrams,
writeups, whatever. Thanks,
A link perhaps?
There is much confusion on this point for which I'm very sorry.
I originally wrote infra
On Thu, 2008-11-20 at 11:06 +0530, Pavan Deolasee wrote:
On Mon, Nov 17, 2008 at 9:01 PM, Simon Riggs [EMAIL PROTECTED]
wrote:
It is, in a later version. Apologies if you're reviewing the
wrong one.
The most recent version I can
On Thu, Nov 20, 2008 at 3:12 PM, Simon Riggs [EMAIL PROTECTED] wrote:
The latest Hot Standby patch includes the latest version of
infrastructure changes patch. Thanks for reviewing.
Do you intend to split the patch into smaller pieces ? The latest hot
standby patch is almost 10K+ lines.
On Thu, 2008-11-20 at 15:19 +0530, Pavan Deolasee wrote:
Do you intend to split the patch into smaller pieces ? The latest hot
standby patch is almost 10K+ lines. Splitting that would definitely
help the review process.
If it helps you, then I'll do it. Hang on an hour or so.
--
Simon
On Mon, Nov 17, 2008 at 9:01 PM, Simon Riggs [EMAIL PROTECTED] wrote:
It is, in a later version. Apologies if you're reviewing the wrong one.
The most recent version I can find is v9, but I remember you mentioned v10
somewhere else.
Can you please confirm if v9 is the latest version and point
Simon Riggs wrote:
diff --git a/src/backend/access/transam/subtrans.c b/src/backend/access/transam/
index 063b366..5e64cb4 100644
--- a/src/backend/access/transam/subtrans.c
+++ b/src/backend/access/transam/subtrans.c
@@ -226,6 +226,9 @@ ZeroSUBTRANSPage(int pageno)
*
* oldestActiveXID is
Simon Riggs wrote:
@@ -3845,6 +3850,52 @@ sigusr1_handler(SIGNAL_ARGS)
PG_SETMASK(BlockSig);
+ if (CheckPostmasterSignal(PMSIGNAL_RECOVERY_START))
+ {
+ Assert(pmState == PM_STARTUP);
+
+ /*
+* Go to shutdown mode if a shutdown
This comment in XLogFlush is no longer accurate:
* The current approach is to ERROR under normal conditions, but only
* WARNING during recovery, so that the system can be brought up even if
* there's a corrupt LSN. Note that for calls from xact.c, the ERROR
will
On Mon, 2008-11-17 at 15:51 +0200, Heikki Linnakangas wrote:
Simon Riggs wrote:
diff --git a/src/backend/access/transam/subtrans.c
b/src/backend/access/transam/
index 063b366..5e64cb4 100644
--- a/src/backend/access/transam/subtrans.c
+++ b/src/backend/access/transam/subtrans.c
@@
On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:
+
+ /*
+* Load the flat authorization file into
postmaster's ca
+* startup process won't have recomputed
this from the d
+* yet,
On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:
Simon Riggs wrote:
@@ -3845,6 +3850,52 @@ sigusr1_handler(SIGNAL_ARGS)
PG_SETMASK(BlockSig);
+ if (CheckPostmasterSignal(PMSIGNAL_RECOVERY_START))
+ {
+ Assert(pmState == PM_STARTUP);
On Tue, Nov 18, 2008 at 12:39 AM, Simon Riggs [EMAIL PROTECTED] wrote:
On Mon, 2008-11-17 at 16:18 +0200, Heikki Linnakangas wrote:
Simon Riggs wrote:
@@ -3845,6 +3850,52 @@ sigusr1_handler(SIGNAL_ARGS)
PG_SETMASK(BlockSig);
+ if
On Fri, 2008-11-07 at 15:44 -0800, Jeff Davis wrote:
Is there a way to avoid wiping A and making a new base backup?
rsync
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Tue, 2008-09-30 at 23:52 +0100, Simon Riggs wrote:
* optional recovery_safe_start_location parameter now provided in
recovery.conf, to allow a consistency point to be manually defined if a
base backup was not taken using standard pg_start/stop backup functions
If using synchronous
Simon Riggs wrote:
* optional recovery_safe_start_location parameter now provided in
recovery.conf, to allow a consistency point to be manually defined if a
base backup was not taken using standard pg_start/stop backup functions
Do we want to cater for that? It only seems safe if you have
On Wed, 2008-10-08 at 14:43 +0300, Heikki Linnakangas wrote:
Simon Riggs wrote:
* optional recovery_safe_start_location parameter now provided in
recovery.conf, to allow a consistency point to be manually defined if a
base backup was not taken using standard pg_start/stop backup functions
22 matches
Mail list logo
