On 05 April 2014 04:14, Tom Lane
[ pgctl_win32service_rel_dbpath_v6.patch ]
Committed with minor corrections, mostly but not all cosmetic.
Thanks a lot...
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
Rajeev rastogi rajeev.rast...@huawei.com writes:
[ pgctl_win32service_rel_dbpath_v6.patch ]
Committed with minor corrections, mostly but not all cosmetic.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
While registering the service for PostgreSQL on windows, we cannot expect user
to give absolute path always.
So it is required to support relative path as data directory. So this patch
will be very useful to handle the same.
This patch has been in Ready for committer stage for long time.
Please
From: Rajeev rastogi rajeev.rast...@huawei.com
Please find the attached modified patch.
Thanks, reviewed and made this patch ready for committer.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On 22 February 2014 06:16, MauMau Wrote:
Thanks for reviewing again.
Please make small cosmetic changes so that make_absolute_path() follows
the
style of other parts. Then I'll make this ready for committer.
(1)
Add the function name in the comment as in:
/*
* make_absolute_path
*
Hi Rajeev,
From: Rajeev rastogi rajeev.rast...@huawei.com
Changed the patch as per your suggestion.
Now only one version of make_absolute_path there defined in src/port/path.c
Found one small memory leak in the existing function
make_absolute_path(miscinit.c),
fixed the same.
Thanks for
On 18 February 2014 21:47, MauMau Wrote:
We already have two different versions of make_absolute_path() in the
tree
- one in src/backend/utils/init/miscinit.c and one in
src/test/regress/pg_regress.c.
I don't think we need a third one.
If we put it in port/ like this patch done,
On Mon, Feb 3, 2014 at 3:06 PM, MauMau maumau...@gmail.com wrote:
From: Rajeev rastogi rajeev.rast...@huawei.com
I will update commitFest with the latest patch immediately after sending
the mail.
OK, done setting the status to ready for committer.
We already have two different versions
From: Magnus Hagander mag...@hagander.net
We already have two different versions of make_absolute_path() in the tree
- one in src/backend/utils/init/miscinit.c and one in
src/test/regress/pg_regress.c.
I don't think we need a third one.
If we put it in port/ like this patch done, then we
From: Rajeev rastogi rajeev.rast...@huawei.com
Please find the attached revised patch.
Thanks, your patch looks good. I confirmed the following:
* Applied cleanly to the latest source tree, and built on Linux and Windows
(with MSVC) without any warnings.
* Changed to D:\ and ran pg_ctl
From: Rajeev rastogi rajeev.rast...@huawei.com
I will update commitFest with the latest patch immediately after sending
the mail.
OK, done setting the status to ready for committer.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
11 matches
Mail list logo
