Re: [HACKERS] Add more tests on event triggers

2015-03-06 Thread Alvaro Herrera
Robert Haas wrote: > On Wed, Feb 25, 2015 at 10:03 AM, Fabien COELHO wrote: > >> You can add tests in src/test/modules/dummy_seclabel. > > > > Patch attached to test sec label there, in addition to the other more > > standard checks in event_trigger. > > These tests seem worthwhile to me. Pushed

Re: [HACKERS] Add more tests on event triggers

2015-03-03 Thread Robert Haas
On Wed, Feb 25, 2015 at 10:03 AM, Fabien COELHO wrote: >> You can add tests in src/test/modules/dummy_seclabel. > > Patch attached to test sec label there, in addition to the other more > standard checks in event_trigger. These tests seem worthwhile to me. -- Robert Haas EnterpriseDB: http://ww

Re: [HACKERS] Add more tests on event triggers

2015-02-25 Thread Fabien COELHO
You can add tests in src/test/modules/dummy_seclabel. Patch attached to test sec label there, in addition to the other more standard checks in event_trigger. -- Fabien.diff --git a/src/test/modules/dummy_seclabel/expected/dummy_seclabel.out b/src/test/modules/dummy_seclabel/expected/dummy_s

Re: [HACKERS] Add more tests on event triggers

2015-02-25 Thread Fabien COELHO
I have left out "SECURITY LABEL" which would require a special security label provider. [...] You can add tests in src/test/modules/dummy_seclabel. Thanks for the pointer, I have indeed missed these special tests. I'll have a look. -- Fabien. -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] Add more tests on event triggers

2015-02-25 Thread Alvaro Herrera
Fabien COELHO wrote: > > Here are some more tests for event triggers, especially about new features > introduced recently in 296f3a6053844089bc533630fffafaba8f016384. > > Check that COMMENT, GRANT and REVOKE do trigger some events. > > The patch also check some more error cases: SQL function, fu