Re: [HACKERS] Add regression tests for DISCARD

2013-07-15 Thread Robert Haas
On Sat, Jul 6, 2013 at 11:49 PM, Robins Tharakan wrote: > Thanks Fabrizio. > > Although parallel_schedule was a miss for this specific patch, however, I > guess I seem to have missed out serial_schedule completely (in all patches) > and then thanks for pointing this out. Subsequently Robert too no

Re: [HACKERS] Add regression tests for DISCARD

2013-07-10 Thread Fabrízio de Royes Mello
On Sun, Jul 7, 2013 at 12:49 AM, Robins Tharakan wrote: > Thanks Fabrizio. > > Although parallel_schedule was a miss for this specific patch, however, I > guess I seem to have missed out serial_schedule completely (in all patches) > and then thanks for pointing this out. Subsequently Robert too n

Re: [HACKERS] Add regression tests for DISCARD

2013-07-07 Thread Robins Tharakan
On 7 July 2013 14:08, Jeff Janes wrote: > Why does serial_schedule even exist? Couldn't we just run the > parallel schedule serially, like what happens when MAX_CONNECTIONS=1? > Well, I am sure it works that way, without errors. The 'why' still eludes me though, just that its required for this

Re: [HACKERS] Add regression tests for DISCARD

2013-07-07 Thread Jeff Janes
On Sat, Jul 6, 2013 at 8:49 PM, Robins Tharakan wrote: > Thanks Fabrizio. > > Although parallel_schedule was a miss for this specific patch, however, I > guess I seem to have missed out serial_schedule completely (in all patches) > and then thanks for pointing this out. Subsequently Robert too not

Re: [HACKERS] Add regression tests for DISCARD

2013-07-06 Thread Robins Tharakan
Thanks Fabrizio. Although parallel_schedule was a miss for this specific patch, however, I guess I seem to have missed out serial_schedule completely (in all patches) and then thanks for pointing this out. Subsequently Robert too noticed the miss at the serial_schedule end. Please find attached a

Re: [HACKERS] Add regression tests for DISCARD

2013-07-02 Thread Fabrízio de Royes Mello
On Mon, Jul 1, 2013 at 5:59 PM, Robins Tharakan wrote: > > Thanks Marko for pointing out about guc.sql. > > Please find attached a patch to move DISCARD related tests from guc.sql to > discard.sql. It adds an extra test for a DISCARD PLANS line, although I > amn't sure on how to validate that its

Re: [HACKERS] Add regression tests for DISCARD

2013-07-01 Thread Robins Tharakan
On 17 June 2013 18:14, Marko Kreen wrote: > Perhaps existing tests in guc.sql should be merged into it? > > Thanks Marko for pointing out about guc.sql. Please find attached a patch to move DISCARD related tests from guc.sql to discard.sql. It adds an extra test for a DISCARD PLANS line, althoug

Re: [HACKERS] Add regression tests for DISCARD

2013-06-17 Thread Marko Kreen
On Mon, May 13, 2013 at 2:58 AM, Robins Tharakan wrote: > Please find attached a patch that adds basic regression tests for DISCARD > command. > > Any and all feedback is obviously welcome. Perhaps existing tests in guc.sql should be merged into it? -- marko -- Sent via pgsql-hackers mailing