Re: [HACKERS] Bogus cleanup code in PostgresNode.pm

2016-04-27 Thread Alvaro Herrera
Michael Paquier wrote: > On Tue, Apr 26, 2016 at 2:24 PM, Tom Lane wrote: > > Now, whether using END is really an improvement is a separate question. > > I have the impression that END calls happen in a better-defined order, > > but I'm not a perl monk. > > For the archive's sake, 08af9219 is the

Re: [HACKERS] Bogus cleanup code in PostgresNode.pm

2016-04-26 Thread Michael Paquier
On Tue, Apr 26, 2016 at 2:24 PM, Tom Lane wrote: > Now, whether using END is really an improvement is a separate question. > I have the impression that END calls happen in a better-defined order, > but I'm not a perl monk. For the archive's sake, 08af9219 is the result commit. -- Michael -- S

Re: [HACKERS] Bogus cleanup code in PostgresNode.pm

2016-04-25 Thread Tom Lane
Michael Paquier writes: > On Mon, Apr 25, 2016 at 11:51 PM, Tom Lane wrote: >> I believe we can fix this by forcing postmaster shutdown in an END >> routine instead of a DESTROY routine, and hence propose the attached >> patch, which does things in the right order for me. I'm a pretty >> poor Pe

Re: [HACKERS] Bogus cleanup code in PostgresNode.pm

2016-04-25 Thread Michael Paquier
On Mon, Apr 25, 2016 at 11:51 PM, Tom Lane wrote: > I noticed that even when they are successful, buildfarm members bowerbird > and jacana tend to spew a lot of messages like this in their bin-check > steps: > > Can't remove directory > /home/pgrunner/bf/root/HEAD/pgsql.build/src/bin/scripts/tmp_