Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Tom Lane
"Dann Corbit" writes: >> From: Andrew Dunstan [mailto:and...@dunslane.net] >> Why won't >> PQstatus(conn) == CONNECTION_OK >> be true and thus the code will succeed without requiring a password? > It returns the value CONNECTION_STARTED It certainly shouldn't. You're effectively asserting that

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Dann Corbit
Pg_ctl.exe is exiting with a success code from line 1946 of PG_CTL.C This is not appropriate behavior for a service unless shutdown has been requested. > -Original Message- > From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers- > ow...@postgresql.org] On Behalf Of Dann Corbit >

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Andrew Dunstan
Dann Corbit wrote: -Original Message- From: Andrew Dunstan [mailto:and...@dunslane.net] Sent: Tuesday, April 28, 2009 2:27 PM To: Dann Corbit Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Building Postgresql under Windows question Dann Corbit wrote: In this function

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Dann Corbit
> -Original Message- > From: Andrew Dunstan [mailto:and...@dunslane.net] > Sent: Tuesday, April 28, 2009 2:27 PM > To: Dann Corbit > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Building Postgresql under Windows question > > > > Dann Corb

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Andrew Dunstan
Dann Corbit wrote: In this function: static bool test_postmaster_connection(bool do_checkpoint) This code will never succeed: snprintf(connstr, sizeof(connstr), "dbname=postgres port=%s connect_timeout=5", portstr); for (i = 0; i < wait_seconds; i++)

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Dann Corbit
In this function: static bool test_postmaster_connection(bool do_checkpoint) This code will never succeed: snprintf(connstr, sizeof(connstr), "dbname=postgres port=%s connect_timeout=5", portstr); for (i = 0; i < wait_seconds; i++) {

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Dann Corbit
> -Original Message- > From: Andrew Dunstan [mailto:and...@dunslane.net] > Sent: Tuesday, April 28, 2009 12:42 PM > To: Dann Corbit > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Building Postgresql under Windows question > > > > Dann Corbit wr

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Dann Corbit
> -Original Message- > From: Andrew Dunstan [mailto:and...@dunslane.net] > Sent: Tuesday, April 28, 2009 12:42 PM > To: Dann Corbit > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Building Postgresql under Windows question > > > > Dann Corbit wr

Re: [HACKERS] Building Postgresql under Windows question

2009-04-28 Thread Andrew Dunstan
Dann Corbit wrote: Pg_ctl.exe is exiting with a success code from line 1946 of PG_CTL.C This is not appropriate behavior for a service unless shutdown has been requested. pg_ctl calls *StartServiceCtrlDispatcher*(). It can only get to the line you mention when called as a service after t