Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-12-13 Thread Fabrízio de Royes Mello
Em sábado, 13 de dezembro de 2014, Andrew Dunstan escreveu: > > On 11/03/2014 07:35 AM, Fabrízio de Royes Mello wrote: > >> On Mon, Nov 3, 2014 at 3:12 AM, Rushabh Lathia > > wrote: >> > >> > Patch looks good, assigning to committer. >> > >> >> Thanks for your rev

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-12-13 Thread Andrew Dunstan
On 11/03/2014 07:35 AM, Fabrízio de Royes Mello wrote: On Mon, Nov 3, 2014 at 3:12 AM, Rushabh Lathia mailto:rushabh.lat...@gmail.com>> wrote: > > Patch looks good, assigning to committer. > Thanks for your review! Committed. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-11-03 Thread Fabrízio de Royes Mello
On Mon, Nov 3, 2014 at 3:12 AM, Rushabh Lathia wrote: > > Patch looks good, assigning to committer. > Thanks for your review! -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.c

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-11-02 Thread Rushabh Lathia
Patch looks good, assigning to committer. On Fri, Oct 31, 2014 at 8:36 AM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Mon, Oct 27, 2014 at 4:15 AM, Rushabh Lathia > wrote: > > > > Hi All, > > > > - Patch got applied cleanly. > > - Regression make check run fine. > > - Pat

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-10-30 Thread Fabrízio de Royes Mello
On Mon, Oct 27, 2014 at 4:15 AM, Rushabh Lathia wrote: > > Hi All, > > - Patch got applied cleanly. > - Regression make check run fine. > - Patch covered the documentation changes > > Here are few comments: > > 1) What the need of following change: > > diff --git a/src/backend/storage/lmgr/lwlock.

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-10-26 Thread Rushabh Lathia
Hi All, - Patch got applied cleanly. - Regression make check run fine. - Patch covered the documentation changes Here are few comments: 1) What the need of following change: diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c index bcec173..9fe6855 100644 --- a/sr

Re: [HACKERS] CINE in CREATE TABLE AS ... and CREATE MATERIALIZED VIEW ...

2014-10-14 Thread Fabrízio de Royes Mello
On Wed, Oct 1, 2014 at 9:17 AM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > We already have IF NOT EXISTS for CREATE TABLE. There are some reason to don't have to CREATE TABLE AS and CREATE MATERIALIZED VIEW?? > Patch attached to add CINE support to: - CREATE TABLE A