Re: [HACKERS] Commit subject line

2013-05-06 Thread Heikki Linnakangas
On 06.05.2013 20:12, Bruce Momjian wrote: On Mon, May 6, 2013 at 06:41:53PM +0200, Magnus Hagander wrote: So what should our goal length be? Different tools seem to have different truncation points, so it sounds like the rule is something like: If you can keep it under 50 characters, great.

Re: [HACKERS] Commit subject line

2013-05-06 Thread Bruce Momjian
On Mon, May 6, 2013 at 06:41:53PM +0200, Magnus Hagander wrote: > > In practice, something else must be further truncating it, at about 64 chars > > by the look of it - see for example > > > > Ha. Good point. There's

Re: [HACKERS] Commit subject line

2013-05-06 Thread Magnus Hagander
On Mon, May 6, 2013 at 4:47 PM, Andrew Dunstan wrote: > > On 05/06/2013 10:19 AM, Magnus Hagander wrote: >> >> On Fri, May 3, 2013 at 9:07 PM, Andres Freund >> wrote: >>> >>> On 2013-05-03 14:54:23 -0400, Andrew Dunstan wrote: On 05/03/2013 02:43 PM, Tom Lane wrote: > > Heikki L

Re: [HACKERS] Commit subject line

2013-05-06 Thread Andrew Dunstan
On 05/06/2013 10:19 AM, Magnus Hagander wrote: On Fri, May 3, 2013 at 9:07 PM, Andres Freund wrote: On 2013-05-03 14:54:23 -0400, Andrew Dunstan wrote: On 05/03/2013 02:43 PM, Tom Lane wrote: Heikki Linnakangas writes: On 03.05.2013 20:56, Bruce Momjian wrote: On Fri, May 3, 2013 at 01:4

Re: [HACKERS] Commit subject line

2013-05-06 Thread Magnus Hagander
On Fri, May 3, 2013 at 9:07 PM, Andres Freund wrote: > On 2013-05-03 14:54:23 -0400, Andrew Dunstan wrote: >> >> On 05/03/2013 02:43 PM, Tom Lane wrote: >> >Heikki Linnakangas writes: >> >>On 03.05.2013 20:56, Bruce Momjian wrote: >> >>>On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wro

Re: [HACKERS] Commit subject line

2013-05-04 Thread Greg Stark
On Fri, May 3, 2013 at 7:54 PM, Andrew Dunstan wrote: > I'd be happy to use 75 or whatever if we could convince the email tools not > to truncate the subject lines at 50. Usually even truncated lines are still useful. Just try to avoid lines like This commit adds new code to implement a new fe

Re: [HACKERS] Commit subject line

2013-05-03 Thread Andres Freund
On 2013-05-03 14:54:23 -0400, Andrew Dunstan wrote: > > On 05/03/2013 02:43 PM, Tom Lane wrote: > >Heikki Linnakangas writes: > >>On 03.05.2013 20:56, Bruce Momjian wrote: > >>>On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: > Yeah. The recommended style is to have the first l

Re: [HACKERS] Commit subject line

2013-05-03 Thread Andrew Dunstan
On 05/03/2013 02:43 PM, Tom Lane wrote: Heikki Linnakangas writes: On 03.05.2013 20:56, Bruce Momjian wrote: On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: Yeah. The recommended style is to have the first line be 50 chars or less, which is a bit unfortunate - it can be a cha

Re: [HACKERS] Commit subject line

2013-05-03 Thread Andrew Dunstan
On 05/03/2013 01:56 PM, Bruce Momjian wrote: On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: On 05/03/2013 01:23 PM, Bruce Momjian wrote: Not sure if I mentioned this, but having first line of the commit be a subject has save me lots of time in writing the release notes. I kno

Re: [HACKERS] Commit subject line

2013-05-03 Thread Tom Lane
Heikki Linnakangas writes: > On 03.05.2013 20:56, Bruce Momjian wrote: >> On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: >>> Yeah. The recommended style is to have the first line be 50 chars or >>> less, which is a bit unfortunate - it can be a challenge to keep to >>> that limit

Re: [HACKERS] Commit subject line

2013-05-03 Thread Bruce Momjian
On Fri, May 3, 2013 at 09:08:08PM +0300, Heikki Linnakangas wrote: > On 03.05.2013 20:56, Bruce Momjian wrote: > >On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: > >> > >>On 05/03/2013 01:23 PM, Bruce Momjian wrote: > >>>Not sure if I mentioned this, but having first line of the co

Re: [HACKERS] Commit subject line

2013-05-03 Thread Heikki Linnakangas
On 03.05.2013 20:56, Bruce Momjian wrote: On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: On 05/03/2013 01:23 PM, Bruce Momjian wrote: Not sure if I mentioned this, but having first line of the commit be a subject has save me lots of time in writing the release notes. I know i

Re: [HACKERS] Commit subject line

2013-05-03 Thread Bruce Momjian
On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote: > > On 05/03/2013 01:23 PM, Bruce Momjian wrote: > >Not sure if I mentioned this, but having first line of the commit be a > >subject has save me lots of time in writing the release notes. I know > >it is helpful to others too who br

Re: [HACKERS] Commit subject line

2013-05-03 Thread Andrew Dunstan
On 05/03/2013 01:23 PM, Bruce Momjian wrote: Not sure if I mentioned this, but having first line of the commit be a subject has save me lots of time in writing the release notes. I know it is helpful to others too who browse our commits on websites. Yeah. The recommended style is to have th