Re: [HACKERS] Crash with empty dictionary

2007-08-22 Thread Hamid Quddus Akhtar
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: I'm not sure if this is a sane way to set up a dictionary, but surely seg faulting is not the right thing to do. Should we throw an error on an empty dict file, or should we swallow it without crashing? Offhand I'd say that

Re: [HACKERS] Crash with empty dictionary

2007-08-22 Thread Tom Lane
Hamid Quddus Akhtar [EMAIL PROTECTED] writes: Offhand I'd say that an empty file is a legitimate corner case, so we should just take it silently. Shouldn't we be warning about an empty file rather than just swallowing up the error? You are jumping to a conclusion, namely that it is an

Re: [HACKERS] Crash with empty dictionary

2007-08-22 Thread Bruce Momjian
Tom Lane wrote: Hamid Quddus Akhtar [EMAIL PROTECTED] writes: Offhand I'd say that an empty file is a legitimate corner case, so we should just take it silently. Shouldn't we be warning about an empty file rather than just swallowing up the error? You are jumping to a conclusion,

Re: [HACKERS] Crash with empty dictionary

2007-08-22 Thread Heikki Linnakangas
Bruce Momjian wrote: Tom Lane wrote: Hamid Quddus Akhtar [EMAIL PROTECTED] writes: Offhand I'd say that an empty file is a legitimate corner case, so we should just take it silently. Shouldn't we be warning about an empty file rather than just swallowing up the error? You are jumping to a

Re: [HACKERS] Crash with empty dictionary

2007-08-21 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: I'm not sure if this is a sane way to set up a dictionary, but surely seg faulting is not the right thing to do. Should we throw an error on an empty dict file, or should we swallow it without crashing? Offhand I'd say that an empty file is a