Re: [HACKERS] Fix compiler warnings in Cube Extension

2015-12-28 Thread David Rowley
On 29 December 2015 at 07:38, Tom Lane wrote: > David Rowley writes: > > My compiler is complaining about cube_coord() and cube_coord_llur() not > > returning a value on all code paths. > > Yeah, looking at that code, this would be expected from any compiler > that doesn't know that ereport() do

Re: [HACKERS] Fix compiler warnings in Cube Extension

2015-12-28 Thread Tom Lane
David Rowley writes: > My compiler is complaining about cube_coord() and cube_coord_llur() not > returning a value on all code paths. Yeah, looking at that code, this would be expected from any compiler that doesn't know that ereport() doesn't return. On it now. The documentation aspect of that