Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-15 Thread Peter Eisentraut
Greg Stark wrote: > Perhaps the flags need to be in a separate variable instead of CFLAGS > specifically advertised to ensure the flags will show up in both > compile and linking lines. CFLAGS ordinarily does show up in both of these places. Where it doesn't, it should be added. -- Peter Eisen

Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-14 Thread Greg Stark
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Donnerstag, 12. April 2007 17:08 schrieb Gregory Stark: > > Unless there's a makefile variable that is included in both CFLAGS and > > LDFLAGS that the user could use instead? But then that wouldn't work on > > architectures where ld is used instea

Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-12 Thread Peter Eisentraut
Am Donnerstag, 12. April 2007 17:08 schrieb Gregory Stark: > Unless there's a makefile variable that is included in both CFLAGS and > LDFLAGS that the user could use instead? But then that wouldn't work on > architectures where ld is used instead of gcc for linking. Perhaps you should start by def

Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-12 Thread Gregory Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: > > %.so: %.o > > ! $(CC) -shared -o $@ $< > > > sqlmansect = 7 > > --- 11,16 > > endif > > > %.so: %.o > > ! $(CC) $(CFLAGS) -shared -o $@ $< > > Surely CFLAGS should be irrelevant at link t

Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-11 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > %.so: %.o > ! $(CC) -shared -o $@ $< > sqlmansect = 7 > --- 11,16 > endif > %.so: %.o > ! $(CC) $(CFLAGS) -shared -o $@ $< Surely CFLAGS should be irrelevant at link time. Maybe LDFLAGS? regards, tom

Re: [HACKERS] Makefile patch to make gcov work on Postgres contrib modules

2007-04-11 Thread Peter Eisentraut
Gregory Stark wrote: > Actually better than adding -lcov, I think this rule really ought to > have CFLAGS in it in case there are other CFLAGS that are necessary > at link time. But why would -lcov appear in CFLAGS? If it's a library it should be in LIBS and perhaps in SHLIB_LINK. -- Peter Eis