Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-03-06 Thread kris
On 3 March 2011 06:33, Andy Colson wrote: > On 1/23/2011 5:11 AM, Michael Meskes wrote: >> As I already said when the script was introduced, I would love to have a >> real >> perl solution, but I'm not a perl programmer by any means. >> >> Michael > > I thought Kris was going to work on this, but

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-03-04 Thread Andy Colson
On 3/3/2011 6:49 AM, Michael Meskes wrote: On Wed, Mar 02, 2011 at 01:33:35PM -0600, Andy Colson wrote: I thought Kris was going to work on this, but saw no progress, and I was bored the other day, so I started working on it. Here is a parse.pl, with some major refactoring. I named it with a 2

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-03-03 Thread Michael Meskes
On Wed, Mar 02, 2011 at 01:33:35PM -0600, Andy Colson wrote: > I thought Kris was going to work on this, but saw no progress, and I > was bored the other day, so I started working on it. > > Here is a parse.pl, with some major refactoring. > > I named it with a 2 so I could run it beside the orig

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-03-02 Thread Tom Lane
Andy Colson writes: > Here is a parse.pl, with some major refactoring. > I am sure there are new bugs. I have not run it on anything but 9.0.1. > Are there other .y files you might feed it? (something other than > backend/parser/gram.y?) That's the only file it has to work for. You could t

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-03-02 Thread Andy Colson
On 1/23/2011 5:11 AM, Michael Meskes wrote: On Sat, Jan 22, 2011 at 08:40:13PM -0500, Andrew Dunstan wrote: I think these really need to be rewritten from scratch. They look like they were written by someone who never heard of Perl 5 (it's only about 16 years old). You might remember that we h

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-25 Thread Peter Eisentraut
On sön, 2011-01-23 at 12:23 -0500, Tom Lane wrote: > Andy Colson writes: > > Is there anyway to make bison/yacc/gcc/etc spit out the rule names? > > bison -v produces a debug output file that includes nicely cleaned-up > versions of all the rules. But it includes a lot of other stuff too, > and

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread kris
On 23 January 2011 14:28, Kris Shannon wrote: > On 23 January 2011 13:14, Andrew Dunstan wrote: >> But there are quite a few perlheads around. ISTR Matt Trout was muttering >> about these scripts on IRC recently. > > A quick cleanup of the check_rules.pl... > > It's a starting point at least. >

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread kris
On 24 January 2011 03:06, Andrew Dunstan wrote: > It's doing the right thing. But it's really spaghetti code, generated by > a2p. Matt was just (rightly) offended by the $[ setting, IIRC. > > The point is that it's close to being totally unmaintainable. > > But if you think you can remedy it witho

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Tom Lane
Kris Shannon writes: > What is the minimal perl version that we are requiring these days? 5.8 according to configure. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Tom Lane
Andy Colson writes: > Is there anyway to make bison/yacc/gcc/etc spit out the rule names? bison -v produces a debug output file that includes nicely cleaned-up versions of all the rules. But it includes a lot of other stuff too, and I'm not at all sure that the file format is stable across bison

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Andy Colson
On 01/23/2011 10:06 AM, Andrew Dunstan wrote: On 01/23/2011 10:16 AM, Andy Colson wrote: On 01/23/2011 08:29 AM, Andy Colson wrote: On 01/22/2011 09:28 PM, k...@shannon.id.au wrote: On 23 January 2011 13:14, Andrew Dunstan wrote: But there are quite a few perlheads around. ISTR Matt Trout w

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Michael Meskes
On Sun, Jan 23, 2011 at 09:16:33AM -0600, Andy Colson wrote: > Are there other problems with this script? Does it not pull out the rule > names correct all the time or something? What problem was Matt having with > it? No, afaict it works correctly but throws some warnings. Michael -- Michae

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Andrew Dunstan
On 01/23/2011 10:16 AM, Andy Colson wrote: On 01/23/2011 08:29 AM, Andy Colson wrote: On 01/22/2011 09:28 PM, k...@shannon.id.au wrote: On 23 January 2011 13:14, Andrew Dunstan wrote: But there are quite a few perlheads around. ISTR Matt Trout was muttering about these scripts on IRC recent

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Andy Colson
On 01/23/2011 08:29 AM, Andy Colson wrote: On 01/22/2011 09:28 PM, k...@shannon.id.au wrote: On 23 January 2011 13:14, Andrew Dunstan wrote: But there are quite a few perlheads around. ISTR Matt Trout was muttering about these scripts on IRC recently. Ok, so I've figured out what its purpose

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Andrew Dunstan
On 01/23/2011 06:11 AM, Michael Meskes wrote: On Sat, Jan 22, 2011 at 08:40:13PM -0500, Andrew Dunstan wrote: I think these really need to be rewritten from scratch. They look like they were written by someone who never heard of Perl 5 (it's only about 16 years old). You might remember that w

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Andy Colson
On 01/22/2011 09:28 PM, k...@shannon.id.au wrote: On 23 January 2011 13:14, Andrew Dunstan wrote: But there are quite a few perlheads around. ISTR Matt Trout was muttering about these scripts on IRC recently. A quick cleanup of the check_rules.pl... It's a starting point at least. Oh!

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-23 Thread Michael Meskes
On Sat, Jan 22, 2011 at 08:40:13PM -0500, Andrew Dunstan wrote: > I think these really need to be rewritten from scratch. They look > like they were written by someone who never heard of Perl 5 (it's > only about 16 years old). You might remember that we had this discussion before. The script was

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-22 Thread kris
On 23 January 2011 13:14, Andrew Dunstan wrote: > But there are quite a few perlheads around. ISTR Matt Trout was muttering > about these scripts on IRC recently. A quick cleanup of the check_rules.pl... It's a starting point at least. ecpg_prepoc_check_rules_cleanup.patch Description: Binary

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-22 Thread Andrew Dunstan
On 01/22/2011 08:48 PM, Tom Lane wrote: Andrew Dunstan writes: On 01/22/2011 06:06 PM, Tom Lane wrote: On Fedora 14 I see these warnings while building ecpg's preproc.y: Use of assignment to $[ is deprecated at ./parse.pl line 21. Use of assignment to $[ is deprecated at ./check_rules.pl li

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-22 Thread Tom Lane
Andrew Dunstan writes: > On 01/22/2011 06:06 PM, Tom Lane wrote: >> On Fedora 14 I see these warnings while building ecpg's preproc.y: >> >> Use of assignment to $[ is deprecated at ./parse.pl line 21. >> Use of assignment to $[ is deprecated at ./check_rules.pl line 18. >> >> Any Perl experts w

Re: [HACKERS] Perl 5.12 complains about ecpg parser-hacking scripts

2011-01-22 Thread Andrew Dunstan
On 01/22/2011 06:06 PM, Tom Lane wrote: On Fedora 14 I see these warnings while building ecpg's preproc.y: Use of assignment to $[ is deprecated at ./parse.pl line 21. Use of assignment to $[ is deprecated at ./check_rules.pl line 18. Any Perl experts want to make those go away?