Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-14 Thread Bernard Frankpitt
We don't let people add columns to an existing index so I don't see why we should have EXTEND INDEX unless index twiddling is more common with partial indexes. Nothing is common with partial indexes at the moment -- the feature is not currently implemented, and I don't think other

Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-13 Thread Tom Lane
Let's drop the meta-discussions and cut to the chase: given that we are about to re-enable partial indexes, should we try to make EXTEND INDEX work too, or just remove it? The idea of EXTEND INDEX is to allow replacement of a partial index's predicate. However, the implementation only supports

Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-13 Thread Martijn van Oosterhout
On Fri, Jul 13, 2001 at 05:49:56PM -0400, Tom Lane wrote: Let's drop the meta-discussions and cut to the chase: given that we are about to re-enable partial indexes, should we try to make EXTEND INDEX work too, or just remove it? Just a few clarifications: * The reason it didn't go to

Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-13 Thread Martijn van Oosterhout
On Fri, Jul 13, 2001 at 06:34:22PM -0400, Bruce Momjian wrote: Let's drop the meta-discussions and cut to the chase: given that we are about to re-enable partial indexes, should we try to make EXTEND INDEX work too, or just remove it? We don't let people add columns to an existing index

Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-13 Thread Bruce Momjian
* I agree with Tom's assertion that it's an awful lot of complexity for such a marginal gain. Look at the size of the patch and the fact that it has all been useless for the last few years. * I didn't send it to -patches because it's not ready yet. * Only posted a URL, not the patch

Re: [HACKERS] Re: [PATCH] To remove EXTEND INDEX

2001-07-13 Thread Bruce Momjian
Let's drop the meta-discussions and cut to the chase: given that we are about to re-enable partial indexes, should we try to make EXTEND INDEX work too, or just remove it? The idea of EXTEND INDEX is to allow replacement of a partial index's predicate. However, the implementation only