Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-13 Thread Robert Haas
On Thu, Aug 12, 2010 at 9:43 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao masao.fu...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-12 Thread Robert Haas
On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao masao.fu...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't see a guard to prevent it from doing it in all cases. [...] The fix looks

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-12 Thread Fujii Masao
On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao masao.fu...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Robert Haas
On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas robertmh...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't see

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Heikki Linnakangas
On 11/08/10 16:46, Robert Haas wrote: On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masaomasao.fu...@gmail.com wrote: On Tue, Aug 10, 2010 at 9:30 AM, Robert Haasrobertmh...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-11 Thread Fujii Masao
On Wed, Aug 11, 2010 at 11:35 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 11/08/10 16:46, Robert Haas wrote: On Wed, Aug 11, 2010 at 1:17 AM, Fujii Masaomasao.fu...@gmail.com  wrote: On Tue, Aug 10, 2010 at 9:30 AM, Robert Haasrobertmh...@gmail.com  wrote: It

Re: [HACKERS] RecordTransactionCommit() and SharedInvalidationMessages

2010-08-10 Thread Fujii Masao
On Tue, Aug 10, 2010 at 9:30 AM, Robert Haas robertmh...@gmail.com wrote: It appears to me that RecordTransactionCommit() only needs to WAL-log shared invalidation messages when wal_level is hot_standby, but I don't see a guard to prevent it from doing it in all cases. Perhaps right. During