Re: [HACKERS] Show statistics target in \d+

2011-11-05 Thread Magnus Hagander
On Fri, Nov 4, 2011 at 16:13, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Would you find it better if we showed blank (NULL) when it was -1? Yeah, I would.  Seems less confusing. Adjusted per this, renamed to Stats target, and applied. --  Magnus Hagander

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Cédric Villemain
2011/11/4 Magnus Hagander mag...@hagander.net: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Interesting, can the ouput be clear on the value being a default or an explicit stat target ? (not mandatory but I believe I would

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Magnus Hagander
On Fri, Nov 4, 2011 at 14:53, Cédric Villemain cedric.villemain.deb...@gmail.com wrote: 2011/11/4 Magnus Hagander mag...@hagander.net: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Interesting, can the ouput be clear on the

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Robert Haas
On Fri, Nov 4, 2011 at 9:34 AM, Magnus Hagander mag...@hagander.net wrote: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Statistics doesn't seem like a very clear name for the column header. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Magnus Hagander
On Fri, Nov 4, 2011 at 15:06, Robert Haas robertmh...@gmail.com wrote: On Fri, Nov 4, 2011 at 9:34 AM, Magnus Hagander mag...@hagander.net wrote: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Statistics doesn't seem like a

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Robert Haas
On Fri, Nov 4, 2011 at 10:09 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Nov 4, 2011 at 15:06, Robert Haas robertmh...@gmail.com wrote: On Fri, Nov 4, 2011 at 9:34 AM, Magnus Hagander mag...@hagander.net wrote: The attached patch adds a column for statistics target when viewing

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Josh Kupershmidt
On Fri, Nov 4, 2011 at 10:05 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Nov 4, 2011 at 14:53, Cédric Villemain Interesting, can the ouput be clear on the value being a default or an explicit stat target ? (not mandatory but I believe I would like to have it only when the stat

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Stephen Frost
* Magnus Hagander (mag...@hagander.net) wrote: On Fri, Nov 4, 2011 at 15:06, Robert Haas robertmh...@gmail.com wrote: Comments/reivews? Statistics doesn't seem like a very clear name for the column header. Got any ideas for a better one? Statistics Target seemed too long to me, and

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Kevin Grittner
Magnus Hagander mag...@hagander.net wrote: Interesting, can the ouput be clear on the value being a default or an explicit stat target ? (not mandatory but I believe I would like to have it only when the stat target is jnot the default) It shows -1 when it's the default. We could map

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Cédric Villemain
2011/11/4 Josh Kupershmidt schmi...@gmail.com: On Fri, Nov 4, 2011 at 10:05 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Nov 4, 2011 at 14:53, Cédric Villemain Interesting, can the ouput be clear on the value being a default or an explicit stat target ? (not mandatory but I believe I

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Isn't this going to show -1 most of the time? Seems rather useless, not to mention confusing to people who don't know what that means.

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Magnus Hagander
On Fri, Nov 4, 2011 at 15:23, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: The attached patch adds a column for statistics target when viewing tables in psql using \d+. Comments/reivews? Isn't this going to show -1 most of the time?  Seems rather useless,

Re: [HACKERS] Show statistics target in \d+

2011-11-04 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: Would you find it better if we showed blank (NULL) when it was -1? Yeah, I would. Seems less confusing. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your