Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-23 Thread Michael Paquier
On Thu, Oct 23, 2014 at 10:45 AM, Peter Eisentraut wrote: > Committed your patch and tests. > Thanks! -- Michael

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-22 Thread Peter Eisentraut
On 10/21/14 6:19 PM, Michael Paquier wrote: > On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut > wrote: > > While looking at this, I wrote a few tests cases for sequence > privileges, because that was not covered at all. That patch is > attached. > > +1 for

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-21 Thread Fabrízio de Royes Mello
Em terça-feira, 21 de outubro de 2014, Michael Paquier < michael.paqu...@gmail.com> escreveu: > On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut > wrote: > >> While looking at this, I wrote a few tests cases for sequence >> privileges, because that was not covered at all. That patch is attached

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-21 Thread Michael Paquier
On Wed, Oct 22, 2014 at 5:03 AM, Peter Eisentraut wrote: > While looking at this, I wrote a few tests cases for sequence > privileges, because that was not covered at all. That patch is attached. > +1 for those tests. -- Michael

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-21 Thread Peter Eisentraut
On 8/27/14 8:02 AM, Michael Paquier wrote: > In a couple of code paths we do the following to check permissions on an > object: > if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK && > pg_class_aclcheck(relid, userid, ACL_UPDATE) != ACLCHECK_OK) > ereport(ERROR, blah); > > Wou

Re: [HACKERS] Simplify calls of pg_class_aclcheck when multiple modes are used

2014-10-06 Thread Fabrízio de Royes Mello
On Wed, Aug 27, 2014 at 9:02 AM, Michael Paquier wrote: > > Hi all, > > In a couple of code paths we do the following to check permissions on an object: > if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK && > pg_class_aclcheck(relid, userid, ACL_UPDATE) != ACLCHECK_OK) > erep