Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread David Fetter
On Thu, Nov 08, 2012 at 02:35:34PM -0500, Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> A possible objection to this is that most C compilers wouldn't complain > >> if a call site is still trying to use the old convention of passing a > >> CmdType value. In the core code, ther

Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> A possible objection to this is that most C compilers wouldn't complain >> if a call site is still trying to use the old convention of passing a >> CmdType value. In the core code, there are only four call sites and >> three are in rewriteHandler.c itse

Re: [HACKERS] Tweaking ResolveNew's API

2012-11-08 Thread Alvaro Herrera
Tom Lane wrote: > A possible objection to this is that most C compilers wouldn't complain > if a call site is still trying to use the old convention of passing a > CmdType value. In the core code, there are only four call sites and > three are in rewriteHandler.c itself, so this isn't much of a p