Re: [HACKERS] Typo in insert.sgml

2017-08-27 Thread Peter Eisentraut
On 6/20/17 15:03, David G. Johnston wrote: > On Tuesday, June 20, 2017, Robert Haas > wrote: > > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > > wrote: > > On 6/18/17 03:16, Julien Rouhaud wrote: > >> Patch attached. > > > > This was not

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston
On Tue, Jun 20, 2017 at 1:35 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut >> wrote: >>> This was not a typo, this was intentional. > >> To me, Julien's change seems to make it easier to understand, but >> maybe I'm misunderstanding what it's tryi

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Tom Lane
Robert Haas writes: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > wrote: >> This was not a typo, this was intentional. > To me, Julien's change seems to make it easier to understand, but > maybe I'm misunderstanding what it's trying to say in the first place. I think there are two subtl

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston
On Tuesday, June 20, 2017, Robert Haas wrote: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > > wrote: > > On 6/18/17 03:16, Julien Rouhaud wrote: > >> Patch attached. > > > > This was not a typo, this was intentional. > > To me, Julien's change seems to make it easier to understand, but >

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Julien Rouhaud
On 20/06/2017 20:34, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. > Oh, sorry. I'm not a native english speaker, that sounded really weird. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Robert Haas
On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. To me, Julien's change seems to make it easier to understand, but maybe I'm misunderstanding what it's trying to say in the first pl

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Peter Eisentraut
On 6/18/17 03:16, Julien Rouhaud wrote: > Patch attached. This was not a typo, this was intentional. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre