Re: [HACKERS] broken comment justification logic in new pgindent

2005-11-07 Thread Tom Lane
Bruce Momjian writes: > My guess is that there is a one-off bug in there. At least a two-off ... but I think it's more likely some sort of wrong-state error, given the narrow places where it happens. I have not observed any non-comment code being mis-justified, for instance.

Re: [HACKERS] broken comment justification logic in new pgindent

2005-11-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Good point. I see the maximum length changed in this commit: > > revision 1.70 > > date: 2004/10/02 01:10:58; author: momjian; state: Exp; lines: +1 -1 > > Update length from 75 to 79. > > > We were discussing some pgindent issues at tha

Re: [HACKERS] broken comment justification logic in new pgindent

2005-11-07 Thread Tom Lane
Bruce Momjian writes: > Good point. I see the maximum length changed in this commit: > revision 1.70 > date: 2004/10/02 01:10:58; author: momjian; state: Exp; lines: +1 -1 > Update length from 75 to 79. > We were discussing some pgindent issues at that time on hackers, but I

Re: [HACKERS] broken comment justification logic in new pgindent

2005-11-07 Thread Bruce Momjian
Tom Lane wrote: > I'm noticing that the latest pgindent run has frequently rejustified > block comments to end in column 80 or 81, causing them to wrap in an > ugly way (at least in emacs). I thought the agreement was to limit > lines to 79 chars max? > > For one example see lines 475 ff in /src/